GNOME Bugzilla – Bug 778199
hlsdemux: Fix segfault during bitrate switch
Last modified: 2018-11-03 14:04:20 UTC
Target variant stream can be updated in _updtae_playlist()
Created attachment 344970 [details] [review] hlsdemux: Fix segfault during bitrate switch
Since error log includes private uri, I cannot attach it, sorry. Sometimes, segfault happen at https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/hls/gsthlsdemux.c#n1556 The cause is updated current_variant. Inside of _update_playlist(), demux's current variant can be updated by https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/hls/gsthlsdemux.c#n1374 and https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/hls/gsthlsdemux.c#n1250
Review of attachment 344970 [details] [review]: This seems like it should be solved at a different place because ::: ext/hls/gsthlsdemux.c @@ +1568,3 @@ gchar *uri; + uri = gst_m3u8_get_uri (demux->current_variant->m3u8); This seems to defeat the purpose of the code below, where new_variant is updated before going to retry_failover_protection
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/516.