After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778156 - Consistently handle relocatable schemas
Consistently handle relocatable schemas
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-03 20:56 UTC by Michael Catanzaro
Modified: 2017-02-04 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Merge ephy permissions gschema into main gschema (9.04 KB, patch)
2017-02-04 19:18 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2017-02-03 20:56:16 UTC 
When Gustavo added the hosts (now renamed to permissions) schema, he put it in a separate .gschema file to indicate that it was separate from all the other settings and relocatable.

Now we have changed the UI schema to be relocatable, but it's still in the same .gschema file as the other settings. We should either split it to a new file, or more likely merge the permissions schema into the main one. Carlos, what's your preference?
Comment 1 Carlos Garcia Campos 2017-02-04 07:06:52 UTC 
I don't have an opinion, the result is the same, I guess. The notification permissions are not actually settings, so maybe it makes sense to have them in a different place. What we have in the main file could be settings as what can be configured in the prefs dialog, or hidden because it's an "advance" setting. So, if you want to split in files for whatever reason, maybe I would move state and lockdown to their own files.
Comment 2 Michael Catanzaro 2017-02-04 19:18:10 UTC 
The following fix has been pushed:
f13c8dc Merge ephy permissions gschema into main gschema
Comment 3 Michael Catanzaro 2017-02-04 19:18:13 UTC 
Created attachment 344945 [details] [review]
Merge ephy permissions gschema into main gschema

There's no real good reason to have it in a separate file.
Comment 4 Michael Catanzaro 2017-02-04 19:18:29 UTC 
(I don't really want to have a bunch of different schema files. :)