Bug 778093 – nm-online: coutdown shows "0s" during the last second

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 778093 - nm-online: coutdown shows "0s" during the last second


Summary:	nm-online: coutdown shows "0s" during the last second


Status:	RESOLVED FIXED

Product:	NetworkManager
Classification:	Platform
Component:	general
Version:	git master
Hardware:	Other Linux

Importance:	Normal minor
Target Milestone:	---
Assigned To:	NetworkManager maintainer(s)
QA Contact:	NetworkManager maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-02-02 17:55 UTC by Mickaël Thomas
Modified:	2017-02-02 23:12 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed patch (563 bytes, patch) 2017-02-02 17:55 UTC, Mickaël Thomas	none	Details \| Review

Description Mickaël Thomas 2017-02-02 17:55:39 UTC

Created attachment 344800 [details] [review]
Proposed patch

When using nm-online -t N, the countdown shows "0s" during the last second.

The countdown value should be rounded up so that "0s" is only shown when the timeout is actually elapsed.

Comment 1 Thomas Haller 2017-02-02 23:12:44 UTC

Thanks!!

merged:

master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=5216754b1ecefbf7ae0f8c1f41f5522bcdfbd517

nm-1-6: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4f58ff5d372d3b7479d78f45a8f55af2d3abaa1a