After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778092 - clutter assigns hardcoded seat0 to libinput
clutter assigns hardcoded seat0 to libinput
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-02 17:53 UTC by Alberts Muktupāvels
Modified: 2017-02-02 22:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backends: Pass seat ID to evdev ClutterDeviceManager (3.24 KB, patch)
2017-02-02 18:05 UTC, Carlos Garnacho 		committed Details | Review

Description Alberts Muktupāvels 2017-02-02 17:53:31 UTC 
Wayland session fails to start, because clutter assigns hardcoded seat0 to libinput in clutter/clutter/evdev/clutter-device-manager-evdev.c.
Comment 1 Carlos Garnacho 2017-02-02 18:05:48 UTC 
Created attachment 344801 [details] [review]
backends: Pass seat ID to evdev ClutterDeviceManager

Clutter assumed seat0 which is most usually, but not always correct.
Add an evdev-backend specific function to allow passing the seat
that will be used for ClutterDeviceManager construction, which we
already obtain in MetaLauncher.
Comment 2 Florian Müllner 2017-02-02 21:38:45 UTC 
Review of attachment 344801 [details] [review]:

LGTM

::: clutter/clutter/evdev/clutter-device-manager-evdev.c
@@ +2806,3 @@
   notify_absolute_motion (pointer_device, ms2us(time_), x, y, NULL);
 }
+

Probably a good idea to add a comment as for clutter_evdev_set_device_callbacks() that the function must be called before clutter_init().
Comment 3 Carlos Garnacho 2017-02-02 22:42:30 UTC 
Thanks :). Added the comment and pushed.

Attachment 344801 [details] pushed as 9c79a16 - backends: Pass seat ID to evdev ClutterDeviceManager