After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778089 - Untranslated app name on the panel
Untranslated app name on the panel
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Indicator
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2017-02-02 16:55 UTC by Piotr Drąg
Modified: 2017-08-03 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the issue (19.28 KB, image/png)
2017-02-02 16:55 UTC, Piotr Drąg 		  Details
data: Fix desktop file generation (1.15 KB, patch)
2017-08-01 21:13 UTC, Piotr Drąg 		none Details | Review
build: Fix desktop file generation (1.15 KB, patch)
2017-08-01 21:18 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2017-02-02 16:55:50 UTC 
Created attachment 344794 [details]
Screenshot of the issue

"Keyboard Layout" on the GNOME Shell panel is in English, even though it is translated in the .po files.

libgnomekbd-3.22.0.1-1.fc25.x86_64
Comment 1 Piotr Drąg 2017-05-20 22:26:08 UTC 
/usr/share/applications/gkbd-keyboard-display.desktop on my system has no translations in it. Maybe .desktop generation is somehow not hooked up properly?

https://git.gnome.org/browse/libgnomekbd/tree/libgnomekbd/Makefile.am#n106
Comment 2 Piotr Drąg 2017-07-03 21:56:48 UTC 
I’m adding Javier to CC, who wrote the rule to create the .desktop files.

Javier, could you please take a look to why it doesn’t work?
Comment 3 Piotr Drąg 2017-08-01 21:13:17 UTC 
Created attachment 356756 [details] [review]
data: Fix desktop file generation

After a ridiculous amount of time spent messing with Autotools, I’ve finally found <https://git.gnome.org/browse/rygel/commit/?id=a4a1aa967d793a4366cae8967cdbdd978d7ba950>. Making the same change in libgnomekbd fixes the issue of .desktop file without translations.

Please review the patch.
Comment 4 Piotr Drąg 2017-08-01 21:18:09 UTC 
Created attachment 356757 [details] [review]
build: Fix desktop file generation

Previous patch had inaccurate subject.
Comment 5 Piotr Drąg 2017-08-02 13:55:25 UTC 
Jens, could I borrow your expertise here? You’re the author of the fix that I want to port from Rygel to libgnomekbd.
Comment 6 Jens Georg 2017-08-03 10:17:12 UTC 
Uh. Let me reconstruct what I did there, I don't remember exactly, but I think the basic key was to switch the order of execution of msgfmt and sed. (might be copy-pasta from somewhere else as well)
Comment 7 Piotr Drąg 2017-08-03 12:21:58 UTC 
So no one knows anything, and everything just gets copied around. Sounds like Autotools. :)

Anyway, thank you. Based on your comment, and the fact that the same fix has been applied to Rygel and GUPnP-tools, I’m going to commit it.