After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778080 - Emit a signal when the SRTP decoder is created
Emit a signal when the SRTP decoder is created
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-02 14:59 UTC by ulfo
Modified: 2018-06-26 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtsp-stream: Emit signal on SRTP decoder creation (1.53 KB, patch)
2017-02-02 14:59 UTC, ulfo 		committed Details | Review

Description ulfo 2017-02-02 14:59:20 UTC 
Created attachment 344783 [details] [review]
rtsp-stream: Emit signal on SRTP decoder creation

Having a reference to the SRTP decoder element makes it possible to trigger re-keying
on an ongoing SRTP stream i.e g_signal_emit_by_name (dec, “request-key”, ssrc). 
Also, true re-keying + MKI support will be probably introduced in libs/srtp2 version 2.1.0
Comment 1 Sebastian Dröge (slomo) 2018-06-26 13:37:14 UTC 
(In reply to ulfo from comment #0)
> Created attachment 344783 [details] [review] [review]
> rtsp-stream: Emit signal on SRTP decoder creation
> 
> Having a reference to the SRTP decoder element makes it possible to trigger
> re-keying
> on an ongoing SRTP stream i.e g_signal_emit_by_name (dec, “request-key”,
> ssrc). 

Why would that be useful? Rekeying happens automatically when needed AFAIU.

> Also, true re-keying + MKI support will be probably introduced in libs/srtp2
> version 2.1.0

What would be needed here then, and what does "true" re-keying (and MKI) mean as compared to what is there now?
Comment 2 Sebastian Dröge (slomo) 2018-06-26 13:38:16 UTC 
Comment on attachment 344783 [details] [review]
rtsp-stream: Emit signal on SRTP decoder creation

Looks good otherwise, but some explanation is needed :)
Comment 3 Sebastian Dröge (slomo) 2018-06-26 13:38:58 UTC 
commit 4d25e04bd75314e2433977490856bc58187edd31 (HEAD -> master)
Author: Ulf Olsson <ulfo@axis.com>
Date:   Wed Feb 1 09:44:50 2017 +0100

    rtsp-stream: Emit a signal when the SRTP decoder is created
    
    https://bugzilla.gnome.org/show_bug.cgi?id=778080