After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778078 - waylandsink: set video surface opaque
waylandsink: set video surface opaque
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.10.x
Other Linux
: Normal normal
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-02 14:11 UTC by Fabien Dessenne
Modified: 2017-04-07 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
waylandsink: set video surface opaque (1.73 KB, patch)
2017-02-02 14:11 UTC, Fabien Dessenne 		none Details | Review
[v2]waylandsink: set video surface opaque (2.14 KB, patch)
2017-02-02 15:51 UTC, Fabien Dessenne 		committed Details | Review

Description Fabien Dessenne 2017-02-02 14:11:25 UTC 
Created attachment 344775 [details] [review]
waylandsink: set video surface opaque

By default, the weston compositor does not consider the video surface as opaque, even if its format has no alpha component (like eg NV12).
Hence, when composing the surfaces, weston considers the hidden black area surface (that embeds the video surface) as a surface to be composed, which is useless.

In order to help the compositor, declare the video surface as opaque (unless it has alpha component).
Comment 1 Nicolas Dufresne (ndufresne) 2017-02-02 14:36:43 UTC 
Review of attachment 344775 [details] [review]:

Looks good to me. Can't we also set that hint on the black background too ? This could possibly be used to optimize some of the rendering in the case their is black borders but another surface (e.g. another app) is completly hidden by the video.
Comment 2 Fabien Dessenne 2017-02-02 15:51:16 UTC 
Created attachment 344791 [details] [review]
[v2]waylandsink: set video surface opaque

v2 patch : as suggested by Nicolas, also make the black area_surface opaque.
Comment 3 Nicolas Dufresne (ndufresne) 2017-02-02 17:07:30 UTC 
Review of attachment 344791 [details] [review]:

Looks good, thanks !
Comment 4 Nicolas Dufresne (ndufresne) 2017-02-02 18:15:21 UTC 
Commited as 57645056ad906a6d997abe6f5134f9b4c595bdf8

Not for next time, we don't used the Signed-by: mark in GStreamer, this
was removed before merging. This patch shall be consider this for 1.10 stable.