GNOME Bugzilla – Bug 778033
Find in conversation does not work anymore
Last modified: 2017-02-28 15:35:43 UTC
After the merge in master of WK2 branch, find in conversation does not work anymore. It does not unfold the message containing the keyword, it does not highlight the instances of found keyword and no way to go to the next item with Ctrl+G shortcut.
Hmm, this seems to work intermittently for me: - Messages with matches in the body aren't unfolded, but they are still highlighted - Message with matches in headers (from, subject, etc) are unfolded Does that match what you are seeing or are you getting something else?
You are right. I didn't test it carefully. After few more tests, I believe that it finds matches only in the current active message. It does not look in all the messages of a conversation. For me only messages with matches in from are unfolded (while messages with matches in subject are not unfolded).
Fix for general search issues just pushed to master as commit ae33745 and subject not being highlighted as commit 928189f. There's an issue highlighting (and hence unfolding) more than one search term die to WK2 API changes, so this issue still exists for account searches (not in-conversation find) with more than one term, just created a bug for that however: Bug 779105. Federico, aside from the above does this take care of the issues you're seeing?
I'm pretty happy with how this is working at the moment, so closing this. If you spot any other issues, please open a new bug.
Yes, it works fine now! Except the CTRL+G shortcut to go to the next found item. Is it already covered by another bug report?
Cool, glad to hear it! Re-enabling Next/Prev is Bug 778021.