GNOME Bugzilla – Bug 777978
Fixups for help text
Last modified: 2020-05-25 10:55:19 UTC
Hi, when reviewing the Swedish help translation I found 5 small things that could be improved: 1. cruel.xml: "Up to thirteen piles, dealt four cards at a time" This looks like it should be "deal" 2. quatorze.xml: "below to the the" Here is a doubled "the" 3. terrace.xml: This xml file uses the spelling "colour" while the rest of the help uses American spelling (color). 4. triple_peaks.xml: "five cards will score 1, 2, 4, 16, and 32 points, for a total of 55" This exponential series looked wrong, so I checked. The correct sequence is the expected 1, 2, 4, 8, 16, and the sum is 31. 5. will_o_the_wisp.xml The difference is small, but this one is called "Will O The Wisp" in the GUI, and "Will o' the Wisp" in the help. Will follow up with a patch that solves point 1 to 4. I leave it to someone else to decide which form is the preferred in point 5.
Created attachment 344642 [details] [review] Spelling and point fixes
Created attachment 344644 [details] [review] Spelling and point fixes On second thought, the cruel sentence is grammatically correct.
Review of attachment 344644 [details] [review]: Thank you for the patch - good catches, everything looks fixed and correct in the patch.
> > > 5. will_o_the_wisp.xml > The difference is small, but this one is called "Will O The Wisp" in the > GUI, and "Will o' the Wisp" in the help. > > > Will follow up with a patch that solves point 1 to 4. I leave it to someone > else to decide which form is the preferred in point 5. Regarding the above issue - I would think the help is correct in the Will o' the Wisp spelling and the UI should be updated, but it is up to a developer.
Paul: What does "reviewed" patch status mean? "accecpted-commit_now"?
Committed in https://gitlab.gnome.org/GNOME/aisleriot/-/commit/cd87c18b2c9bbaae5b5a2dba254c2520d8862c92