GNOME Bugzilla – Bug 777961
Documentation for g_app_info_equals() could be clearer
Last modified: 2017-04-08 05:12:39 UTC
The documentation for “g_app_info_equals()” just reads: “Checks if two #GAppInfos are equal. Returns: %TRUE if @appinfo1 is equal to @appinfo2. %FALSE otherwise.” Which is correct, but makes the reader think that the comparison takes into account the *contents* of the GAppInfo objects. What gets compared is just the application identifier — in Win32 the logic is a bit more elaborate, but essentially not all the bits of contained data are compared either. This has bitten GNOME Shell (see bug #773636) and could end up easily causing bugs in other applications which may need to take into account the contents of the GAppInfo and not just its identifier. There are concerns about extending the comparisons done by “g_app_info_equals()” (see bug #774302), so at least it would be desirable to make a point in the documentation about the behaviour.
Created attachment 344600 [details] [review] Better documentation for g_app_info_equal()
Review of attachment 344600 [details] [review]: Thanks for doing this!
Attachment 344600 [details] pushed as 8588209 - Better documentation for g_app_info_equal()