After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777865 - Do not export methods that are supposed to be private
Do not export methods that are supposed to be private
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-28 09:19 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2017-01-29 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not export methods that are supposed to be private (10.97 KB, patch)
2017-01-28 09:19 UTC, Ignacio Casal Quinteiro (nacho)
committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2017-01-28 09:19:29 UTC
At some point when I added the export flag to the methods I
wanted to match what the regex was exporting, though these
methods are private and I think we can safely stop exporting
them since I hope evince is not actually using them.
Comment 1 Ignacio Casal Quinteiro (nacho) 2017-01-28 09:19:34 UTC
Created attachment 344449 [details] [review]
Do not export methods that are supposed to be private
Comment 2 Ignacio Casal Quinteiro (nacho) 2017-01-28 15:39:29 UTC
Carlos I pushed this by mistake when I wanted to push another g_clear_pointer minor cleanup. Let me know If I should revert it.
Comment 3 Carlos Garcia Campos 2017-01-29 07:42:25 UTC
Comment on attachment 344449 [details] [review]
Do not export methods that are supposed to be private

It's fine