After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777846 - "Remove" should be in headerbar
"Remove" should be in headerbar
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-27 16:13 UTC by Bastien Nocera
Modified: 2017-05-02 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Move Remove button to the header bar (4.20 KB, patch)
2017-05-02 00:00 UTC, Georges Basile Stavracas Neto 		none Details | Review
keyboard: Move Remove button to the header bar (4.32 KB, patch)
2017-05-02 02:03 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Comment 1 Georges Basile Stavracas Neto 2017-05-02 00:00:28 UTC 
Created attachment 350835 [details] [review]
keyboard: Move Remove button to the header bar

According to the mockups [1], the Remove button should
be placed at the start of the header bar. Currently,
however, it is positioned below the custom shortcut edit
button.

Fix that by moving the remove button to the header bar.
Comment 2 Georges Basile Stavracas Neto 2017-05-02 02:03:19 UTC 
Created attachment 350839 [details] [review]
keyboard: Move Remove button to the header bar

Fixed the missing link for the mockups.
Comment 3 Bastien Nocera 2017-05-02 09:22:52 UTC 
Review of attachment 350839 [details] [review]:

That looks fine.
Comment 4 Georges Basile Stavracas Neto 2017-05-02 10:21:38 UTC 
Attachment 350839 [details] pushed as dce6fe6 - keyboard: Move Remove button to the header bar