After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777829 - [Proposal, Enhancement] Add Hangul jamo representation for Hangul Syllables on gucharmap
[Proposal, Enhancement] Add Hangul jamo representation for Hangul Syllables o...
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-27 13:22 UTC by DaeHyun Sung
Modified: 2017-01-28 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Hangul jamo representation for Hangul Syllables on gucharmap (3.72 KB, patch)
2017-01-27 13:22 UTC, DaeHyun Sung
none Details | Review
Change Add Hangul jamo representation for Hangul Syllables on gucharmap (2.95 KB, patch)
2017-01-28 12:04 UTC, DaeHyun Sung
none Details | Review

Description DaeHyun Sung 2017-01-27 13:22:23 UTC
Created attachment 344416 [details] [review]
Add Hangul jamo representation for Hangul Syllables on gucharmap

[Proposal, Enhancement] Add Hangul jamo representation for Hangul Syllables on gucharmap

This is not bug, but I think  that feature enhance gucharmap for Korean learners and Korean users.

I add new feature, “Add Hangul jamo representation for selected Hangul Syllables features on gucharmap”

Hangul elements are commonly referred to as jamo(자모/字母), meaning “alphabet”

Korean has special term for the jamo that are used to construct hangul syllable, depending on where in the syllable they appear:
- Choseong(초성/初聲) for the initial sound, usually a consonant
- Jungseong(중성/中聲) for the middle sound, usually a vowel
- Jongseong(종성/終聲) for the final sound, usually a consonant

Hangul syllables are the characters that are used to express contemporary Korean texts in writing.

Gucharmap’s canonical decomposition Notation appear Hangul jamo for Selected Hangul syllables.
example) 
Canonical decomposition: U+1100 HANGUL CHOSEONG KIYEOK + U+1161 HANGUL JUNGSEONG A

But these jamo name and representation is not appear, so I add “Hangul jamo names and representation for selected hangul syllable” feature on gucharmap.
example)
Canonical decomposition: U+1100 HANGUL CHOSEONG KIYEOK + U+1161 HANGUL JUNGSEONG A

Hangul Choseong:ᄀ
Hangul Jungseong:ᅡ


ex1) Decomposition of hangul syllable 
Unicode codepoint: U+AC00
Hangul(한글) ‘가’ 
jamo(자모/字母): ㄱ plus ㅏ
choseong(초성/初聲): ㄱ (codepoint: U+1100)
jungseong(중성/中聲): ㅏ(codepoint: U+1161)

Selected Hangul syllable ‘가’(U+AC00)
AS-IS 
Canonical decomposition: U+1100 HANGUL CHOSEONG KIYEOK + U+1161 HANGUL JUNGSEONG A

TO-BE
Canonical decomposition: U+1100 HANGUL CHOSEONG KIYEOK + U+1161 HANGUL JUNGSEONG A

Hangul Choseong:ᄀ
Hangul Jungseong:ᅡ

ex2) Decomposition of hangul syllable 
Unicode code point: U+AC01
Hangul(한글) ‘각’
jamo(자모/字母):  ‘ᄀ’  plus ‘ᅡ’  plus ‘ᆨ’ 
choseong(초성/初聲):ㄱ (codepoint: U+1100)
jungseong(중성/中聲):ㅏ(codepoint: U+1161)
jongseong(종성/終聲):ᆨ (codepoint: U+11A8)


Selected Hangul syllable ‘각’(U+AC01)
AS-IS 
Canonical decomposition: U+1100 HANGUL CHOSEONG KIYEOK + U+1161 HANGUL JUNGSEONG A + U+11A8 HANGUL JONGSEONG KIYEOK

TO-BE
Canonical decomposition: U+1100 HANGUL CHOSEONG KIYEOK + U+1161 HANGUL JUNGSEONG A + U+11A8 HANGUL JONGSEONG KIYEOK

Hangul Choseong:ᄀ
Hangul Jungseong:ᅡ
Hangul Jongseong:ᆨ


Reference
Unicode Normalization forms http://unicode.org/reports/tr15/
Unicode Normalization forms #14.1.4. Hangul Decomposition and Composition http://unicode.org/reports/tr15/#Hangul_Composition 
Hangul Jamo (Range: U+1100-U+11FF) http://www.unicode.org/charts/PDF/U1100.pdf 
Hangul Syllables (Range: U+AC00-U+D7AF) http://www.unicode.org/charts/PDF/UAC00.pdf
Comment 1 Christian Persch 2017-01-27 18:49:09 UTC
+  // check Korean alphabet(Hangul Syllables)

C-style comments, please.

+    if (!gucharmap_unichar_validate (decomposition[0])) {

Under which circumstances would any of the elements of @decomposition not be valid?

Instead of adding 3 new lines, would it be enough to add the characters to the decomposition line, like this:

Canonical decomposition: ᄀ U+1100 HANGUL CHOSEONG KIYEOK +  ᅡ U+1161 HANGUL JUNGSEONG A +  ᆨ U+11A8 HANGUL JONGSEONG KIYEOK
Comment 2 DaeHyun Sung 2017-01-28 12:04:02 UTC
Created attachment 344454 [details] [review]
Change Add Hangul jamo representation for Hangul Syllables on gucharmap

change feature about adding Hangul jamo representation for Hangul Syllables on gucharmap
ex) Canonical decomposition: ᄀ U+1100 HANGUL CHOSEONG KIYEOK +  ᅡ U+1161 HANGUL JUNGSEONG A +  ᆨ U+11A8 HANGUL JONGSEONG KIYEOK
Comment 3 DaeHyun Sung 2017-01-28 12:16:13 UTC
After I saw Reviewed Text, I modified some source codes.

1. change C-style comments
2. decomposition result is valid. so I delete "if (!gucharmap_unichar_validate (decomposition[0])) {"
3. Instead of adding 3 new lines, would it be enough to add the characters to the decomposition line, like this:

Canonical decomposition: ᄀ U+1100 HANGUL CHOSEONG KIYEOK +  ᅡ U+1161 HANGUL JUNGSEONG A +  ᆨ U+11A8 HANGUL JONGSEONG KIYEOK

Today is Lunar new year. 
Happy Lunar New Year 2017! Wishing everyone good health and fortune for this Rooster(
Comment 4 Christian Persch 2017-01-28 20:23:03 UTC
Thanks for the patch. I chose to implement this differently by simply making insert_codepoint always print the character too, not just for hangul jamos.