After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777826 - Custom Vala compile rules do not pass -fPIC in CFLAGS
Custom Vala compile rules do not pass -fPIC in CFLAGS
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
0.18.x
Other Linux
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-27 12:20 UTC by David King
Modified: 2017-02-01 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add -fPIC flag to Vala passthrough flags (792 bytes, patch)
2017-01-27 12:21 UTC, David King
none Details | Review

Description David King 2017-01-27 12:20:21 UTC
If building with hardened build flags, such as -fPIC (which the Fedora package builders do), the -fPIC is not passed to the C compiler by the Vala build rule. This leads to a compile failure when building the tests in the Fedora package. The build rule should probably be changed to use the Automake rules (although those are not that great), but it is also sufficient to pass -fPIC straight to the Vala compiler.
Comment 1 David King 2017-01-27 12:21:32 UTC
Created attachment 344408 [details] [review]
add -fPIC flag to Vala passthrough flags
Comment 2 Stef Walter 2017-02-01 11:43:09 UTC
Merged into git master.