After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777821 - ui: Capitalisation and Unicode fixes for translatable strings
ui: Capitalisation and Unicode fixes for translatable strings
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-27 10:08 UTC by Philip Withnall
Modified: 2017-01-30 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ui: Fix capitalisation of a button label (1.22 KB, patch)
2017-01-27 10:08 UTC, Philip Withnall
committed Details | Review
ui: Use Unicode quotation marks and ellipses (4.51 KB, patch)
2017-01-27 10:08 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2017-01-27 10:08:20 UTC
A few small patches attached.
Comment 1 Philip Withnall 2017-01-27 10:08:24 UTC
Created attachment 344386 [details] [review]
ui: Fix capitalisation of a button label

Make the capitalisation consistent within the UI, and consistently
follow the HIG:

https://developer.gnome.org/hig/stable/writing-style.html.en#capitalization
Comment 2 Philip Withnall 2017-01-27 10:08:29 UTC
Created attachment 344387 [details] [review]
ui: Use Unicode quotation marks and ellipses

These look better than straight quotation marks and ellipses.
Comment 3 Rui Matos 2017-01-30 13:46:48 UTC
Review of attachment 344386 [details] [review]:

ok
Comment 4 Rui Matos 2017-01-30 13:49:48 UTC
Review of attachment 344387 [details] [review]:

::: gnome-initial-setup/pages/summary/gis-summary-page.ui
@@ +62,3 @@
               <object class="GtkLabel" id="title">
                 <property name="visible">True</property>
+                <property name="label" translatable="yes">You’re ready to go!</property>

This isn't quotation though, but I'm not a native speaker, does it really look better like this?
Comment 5 Philip Withnall 2017-01-30 14:16:48 UTC
Review of attachment 344387 [details] [review]:

::: gnome-initial-setup/pages/summary/gis-summary-page.ui
@@ +62,3 @@
               <object class="GtkLabel" id="title">
                 <property name="visible">True</property>
+                <property name="label" translatable="yes">You’re ready to go!</property>

It does look better. The right single quotation mark is the preferred Unicode character for an apostrophe: https://en.wikipedia.org/wiki/Apostrophe#Unicode
Comment 6 Rui Matos 2017-01-30 15:20:09 UTC
Review of attachment 344387 [details] [review]:

::: gnome-initial-setup/pages/summary/gis-summary-page.ui
@@ +62,3 @@
               <object class="GtkLabel" id="title">
                 <property name="visible">True</property>
+                <property name="label" translatable="yes">You’re ready to go!</property>

Ok then, thanks for the link and the patches!
Comment 7 Philip Withnall 2017-01-30 15:55:34 UTC
Thanks for the reviews!

Attachment 344386 [details] pushed as b1ac895 - ui: Fix capitalisation of a button label
Attachment 344387 [details] pushed as da81174 - ui: Use Unicode quotation marks and ellipses