After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777819 - tracker-extract-png: Remove some dead code
tracker-extract-png: Remove some dead code
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-01-27 09:05 UTC by Philip Withnall
Modified: 2017-01-27 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker-extract-png: Remove some dead code (1.24 KB, patch)
2017-01-27 09:05 UTC, Philip Withnall 		none Details | Review
Revert "tracker-extract, png: Fix DLNA profiles" (1.44 KB, patch)
2017-01-27 11:07 UTC, Carlos Garnacho 		committed Details | Review

Description Philip Withnall 2017-01-27 09:05:45 UTC 
Trivial patch.
Comment 1 Philip Withnall 2017-01-27 09:05:49 UTC 
Created attachment 344381 [details] [review]
tracker-extract-png: Remove some dead code

Coverity ID: 1298205
Comment 2 Carlos Garnacho 2017-01-27 10:30:30 UTC 
Comment on attachment 344381 [details] [review]
tracker-extract-png: Remove some dead code

I actually think the right fix here is reverting commit 89baaa45a7. I don't know why that was added, but the reasons got lost in the mist of time.
Comment 3 Philip Withnall 2017-01-27 11:06:56 UTC 
Inevitably. :-)  Do you want to go ahead and do that? I don’t know anything about PNG/DLNA profiles.
Comment 4 Carlos Garnacho 2017-01-27 11:07:01 UTC 
Created attachment 344392 [details] [review]
Revert "tracker-extract, png: Fix DLNA profiles"

This reverts commit 89baaa45a70e5d50462bbd4e5b89dbb2c221e701.

The reasons to classify all pngs as PNG_LRG went away with the maemo
bugzilla. The reason isn't clear and seems to go against the DNLA spec
(at least, how gupnp-dlna understands it, which Tracker took inspiration
from). This commit also made the if (profile)... check below useless,
which raised warnings in Coverity.

Coverity ID: 1298205
Comment 5 Philip Withnall 2017-01-27 11:10:04 UTC 
Review of attachment 344392 [details] [review]:

I can confirm that this looks like valid C code.
Comment 6 Carlos Garnacho 2017-01-27 11:15:03 UTC 
Comment on attachment 344392 [details] [review]
Revert "tracker-extract, png: Fix DLNA profiles"

I went ahead and pushed it :). Thanks for double checking!