After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777767 - week view: Don't take so much vertical space that I need to scroll or can miss events on GUI
week view: Don't take so much vertical space that I need to scroll or can mis...
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: Views
unspecified
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-25 22:37 UTC by Christian Stadelmann
Modified: 2017-02-02 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme: reduce vertical padding (896 bytes, patch)
2017-01-26 21:29 UTC, Georges Basile Stavracas Neto 		committed Details | Review
30 minute event (image) (62 bytes, text/plain)
2017-02-02 02:31 UTC, Mohammed Sadiq 		  Details
30 minute event (image) (1.70 KB, image/png)
2017-02-02 02:34 UTC, Mohammed Sadiq 		  Details

Description Christian Stadelmann 2017-01-25 22:37:20 UTC 
I am running gnome-calendar ("master") from gnome nightly apps flatpak repo.

Week view takes very much vertical space so I can only fit 6.5 hours on one screen. Because of that I need to scroll vertically over vast empty space. Users might even believe there is no event today or this week, because week view is not showing any events by default.

To fix this, I suggest a few UI changes:
* Compress sleep times, either by configuration (see bug #746265) or automatically. How about compressing successive hours which are empty over the whole week?
* reduce line height. Does one hour really need enough space for 6 lines of text? Since an event takes 2 lines of text in week view, how about reducing the space to 2 or 4 lines?
Comment 1 Georges Basile Stavracas Neto 2017-01-26 21:29:10 UTC 
Created attachment 344361 [details] [review]
theme: reduce vertical padding

This reduces each hour cell's height, and makes more of the
week grid visible at a glance.
Comment 2 Isaque Galdino 2017-02-01 00:58:44 UTC 
Review of attachment 344361 [details] [review]:

Code change is OK
Comment 3 Christian Stadelmann 2017-02-01 09:28:52 UTC 
Comment on attachment 344361 [details] [review]
theme: reduce vertical padding

This patch is fine, but it doesn't solve the problem for me when applying the CSS in GtkInspector.
Comment 4 Georges Basile Stavracas Neto 2017-02-01 17:08:57 UTC 
Thanks for the review. The vertical padding was reduced so 1/3 of the day is visible on a 1366x748 screen. Please reopen this issue if you think more padding is needed.

Attachment 344361 [details] pushed as ba871e4 - theme: reduce vertical padding
Comment 5 Christian Stadelmann 2017-02-01 17:29:30 UTC 
Thanks!

Do you know how often (or when) the flatpak package will be rebuilt and updated? I would use that to test gnome-calendar. And I cannot figure out any of this through https://sdk.gnome.org/.
Comment 6 Mohammed Sadiq 2017-02-02 02:31:53 UTC 
Created attachment 344755 [details]
30 minute event (image)
Comment 7 Mohammed Sadiq 2017-02-02 02:33:11 UTC 
After this patch, height of 30 minute events exceeds the tile. Please see the attached screenshot above.

Thanks
Comment 8 Mohammed Sadiq 2017-02-02 02:34:17 UTC 
Created attachment 344756 [details]
30 minute event (image)

Sorry. This one is the screenshot.
Comment 9 Georges Basile Stavracas Neto 2017-02-02 10:25:04 UTC 
This is another bug. Could you please open a new ticket? The event widget must adapt the content for when the height is not enough
Comment 10 Christian Stadelmann 2017-02-02 19:40:22 UTC 
flatpak build is updated, bug is fixed. Thanks!