After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777718 - Update imported OSM POI defintions for 3.24
Update imported OSM POI defintions for 3.24
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-24 21:06 UTC by Marcus Lundblad
Modified: 2017-03-07 22:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extractPoiTypesFromID: Adapt to lates iD (917 bytes, patch)
2017-03-06 22:08 UTC, Marcus Lundblad 		committed Details | Review
osmTypes: Update OSM POI definitions (218.35 KB, patch)
2017-03-07 21:04 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2017-01-24 21:06:10 UTC 
Before releasing 3.24 we should re-run the import script against a current checkout of the iD editor to get fresh POI definitions and translations.
Comment 1 Marcus Lundblad 2017-03-06 21:42:18 UTC 
Unfortunatly, iD has changed the layout of the locale preset .json files a bit, so I'll get back with a patch soonish…
Comment 2 Marcus Lundblad 2017-03-06 22:08:05 UTC 
Created attachment 347339 [details] [review]
extractPoiTypesFromID: Adapt to lates iD

iD has changed the format of the locale .json definitions.
Adapt the script to the new format.
Comment 3 Jonas Danielsson 2017-03-07 10:17:28 UTC 
Review of attachment 347339 [details] [review]:

lgtm
Comment 4 Marcus Lundblad 2017-03-07 21:04:41 UTC 
Created attachment 347423 [details] [review]
osmTypes: Update OSM POI definitions

Update OpenStreetMap POI definitions and
translations from a current checkout of
the iD editor.
Comment 5 Mattias Bengtsson 2017-03-07 22:24:43 UTC 
Review of attachment 347423 [details] [review]:

Looks good!
Comment 6 Mattias Bengtsson 2017-03-07 22:24:57 UTC 
Review of attachment 347423 [details] [review]:

Looks good!
Comment 7 Marcus Lundblad 2017-03-07 22:38:52 UTC 
Attachment 347339 [details] pushed as 799f48c - extractPoiTypesFromID: Adapt to lates iD
Attachment 347423 [details] pushed as 5da054a - osmTypes: Update OSM POI definitions