After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777713 - Port away from gnome-common
Port away from gnome-common
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-24 20:29 UTC by Christoph Reiter (lazka)
Modified: 2017-03-20 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix various potential compiler warnings (16.48 KB, patch)
2017-01-24 20:29 UTC, Christoph Reiter (lazka)
committed Details | Review
Port from gnome-common to autoconf-archive (11.64 KB, patch)
2017-01-24 20:30 UTC, Christoph Reiter (lazka)
committed Details | Review
aclocal: make local file discover by reading AC_CONFIG_MACRO_DIR work (4.93 KB, patch)
2017-01-24 20:31 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Christoph Reiter (lazka) 2017-01-24 20:29:21 UTC
https://wiki.gnome.org/Projects/GnomeCommon/Migration

Gives us better warnings by default without breaking the build for users.
Comment 1 Christoph Reiter (lazka) 2017-01-24 20:29:51 UTC
Created attachment 344179 [details] [review]
Fix various potential compiler warnings

This is useful for a the next commit which switches away from
gnome-common and uses AX_COMPILER_FLAGS adding some new compiler
warning flags.
Comment 2 Christoph Reiter (lazka) 2017-01-24 20:30:21 UTC
Created attachment 344180 [details] [review]
Port from gnome-common to autoconf-archive

See https://wiki.gnome.org/Projects/GnomeCommon/Migration

Visible changes:

* --enable-compile-warnings is now [no/auto/yes] instead of
  [no/minimum/yes/maximum/error]
* warnings are errors by default except for releases or if
  --disable-Werror is passed (which is the default in jhbuild)

AX_APPEND_COMPILE_FLAGS() gets used to disable some warnings enabled by
AX_COMPILER_FLAGS() because they trigger with pycairo/python headers.

Tested with gcc 6.3, clang 3.8.1
Comment 3 Christoph Reiter (lazka) 2017-01-24 20:31:00 UTC
Created attachment 344181 [details] [review]
aclocal: make local file discover by reading AC_CONFIG_MACRO_DIR work

aclocal needs to know where the local macros are for including them and
for having a place to put the required system ones in.

Since 1.13 it can parse configure.ac and get the path from AC_CONFIG_MACRO_DIR.
This didn't work because for some reasons it complains if the local macros
start with "AM_" even if they are there (I guess it assumes they can't be local).
To work around that change the AM prefix to PYG.

To work around that, change the AM prefix to PYG, bump the automake version so
we can asume aclocal finds it and remove the hardcoded paths from both
autogen.sh and Makefile.am.