After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777707 - Exit gracefully if we are disabled systemwide
Exit gracefully if we are disabled systemwide
Status: RESOLVED WONTFIX
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-24 18:40 UTC by Rui Matos
Modified: 2017-01-31 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
summary: Move stamp file creation to a global function (3.45 KB, patch)
2017-01-24 18:41 UTC, Rui Matos
committed Details | Review
copy-worker: Copy the "done" stamp file too (1.71 KB, patch)
2017-01-24 18:41 UTC, Rui Matos
committed Details | Review
Exit gracefully if we are disabled systemwide (2.98 KB, patch)
2017-01-24 18:41 UTC, Rui Matos
rejected Details | Review

Description Rui Matos 2017-01-24 18:40:57 UTC
See patches.
Comment 1 Rui Matos 2017-01-24 18:41:01 UTC
Created attachment 344173 [details] [review]
summary: Move stamp file creation to a global function

This will be useful in other places. Note that the "done" stamp file
is now created in both existing user and new user modes.
Comment 2 Rui Matos 2017-01-24 18:41:06 UTC
Created attachment 344174 [details] [review]
copy-worker: Copy the "done" stamp file too

For consistency, instead of creating the "done" stamp file here, we
can let g-i-s handle that and just copy it along with all the others.
Comment 3 Rui Matos 2017-01-24 18:41:11 UTC
Created attachment 344175 [details] [review]
Exit gracefully if we are disabled systemwide

Sysadmins might want to disable any kind of initial setup for their
users, perhaps because they pre-configure their environments. We
should provide an easy way to do it.

At least the anaconda installer provides an option to skip any kind
post-install setup tools so, for now we're only adding support for
that but more might be added in the future.
Comment 4 Ray Strode [halfline] 2017-01-26 21:52:00 UTC
Comment on attachment 344173 [details] [review]
summary: Move stamp file creation to a global function

ok
Comment 5 Ray Strode [halfline] 2017-01-26 21:52:35 UTC
Comment on attachment 344174 [details] [review]
copy-worker: Copy the "done" stamp file too

cool
Comment 6 Ray Strode [halfline] 2017-01-26 21:53:53 UTC
Comment on attachment 344175 [details] [review]
Exit gracefully if we are disabled systemwide

this should stay a downstream patch imo
Comment 7 Rui Matos 2017-01-31 12:28:31 UTC
Ok, we'll do this downstream, just pushing the cleanups.

Attachment 344173 [details] pushed as 20266d3 - summary: Move stamp file creation to a global function
Attachment 344174 [details] pushed as 7106bdb - copy-worker: Copy the "done" stamp file too