After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777680 - Gtk won't load due to a missing Color attribute in Gdk
Gtk won't load due to a missing Color attribute in Gdk
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
Git master
Other Linux
: Normal blocker
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-24 05:10 UTC by César Fabián Orccón Chipana
Modified: 2017-01-25 08:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch fixes the bug (as far I have tried). (5.20 KB, patch)
2017-01-24 05:14 UTC, César Fabián Orccón Chipana 		none Details | Review
This patch fixes the bug (as far I have tried). (5.02 KB, patch)
2017-01-24 05:31 UTC, César Fabián Orccón Chipana 		none Details | Review
This patch fixes the bug (as far I have tried). (5.19 KB, patch)
2017-01-24 05:40 UTC, César Fabián Orccón Chipana 		none Details | Review
This patch fixes the bug (as far I have tried). (5.18 KB, patch)
2017-01-24 13:15 UTC, César Fabián Orccón Chipana 		committed Details | Review

Description César Fabián Orccón Chipana 2017-01-24 05:10:04 UTC 
See this for more details:
https://paste.fedoraproject.org/535310/48521614/
Comment 1 César Fabián Orccón Chipana 2017-01-24 05:14:42 UTC 
Created attachment 344091 [details] [review]
This patch fixes the bug (as far I have tried).
Comment 2 César Fabián Orccón Chipana 2017-01-24 05:31:25 UTC 
Created attachment 344093 [details] [review]
This patch fixes the bug (as far I have tried).
Comment 3 César Fabián Orccón Chipana 2017-01-24 05:40:43 UTC 
Created attachment 344094 [details] [review]
This patch fixes the bug (as far I have tried).
Comment 4 Christoph Reiter (lazka) 2017-01-24 07:31:29 UTC 
Review of attachment 344094 [details] [review]:

otherwise lgtm, thanks!

::: gi/overrides/Gtk.py
@@ +1600,3 @@
     __all__.append('stock_lookup')
 
+if Gtk._version in ("4.0"):

nitpick: should be == "4.0"

("4.0") is a string, ("4.0",) is a tuple
Comment 5 César Fabián Orccón Chipana 2017-01-24 13:15:06 UTC 
Created attachment 344149 [details] [review]
This patch fixes the bug (as far I have tried).
Comment 6 Christoph Reiter (lazka) 2017-01-24 19:18:03 UTC 
Review of attachment 344149 [details] [review]:

lgtm
Comment 7 Christoph Reiter (lazka) 2017-01-25 08:06:28 UTC 
thanks