GNOME Bugzilla – Bug 777655
audioringbuffer: more encoded formats
Last modified: 2018-11-03 11:54:11 UTC
This couple patches add Vorbis, FLAC, ALAC, WMA. The last two are untested, but ought to work given the similarity.
Created attachment 344052 [details] [review] vorbis and flac
Created attachment 344053 [details] [review] wma and alac
Created attachment 344062 [details] [review] raw aac
Created attachment 344064 [details] [review] audio: add vorbis and FLAC to GstAudioRingBufferFormatType
Created attachment 344065 [details] [review] audioringbuffer: add Vorbis to GstAudioRingBufferFormatType
Created attachment 344066 [details] [review] audioringbuffer: add wma and alac to encoded audio formats
Merge the FLAC and raw AAC support as we've validated them commit 6134dab3bba13674f82c5befae7e459a67d979ad Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Thu Nov 17 13:04:18 2016 +0000 audio: add FLAC to GstAudioRingBufferFormatType https://bugzilla.gnome.org/show_bug.cgi?id=777655 commit c46607095ea5dab7bf42d7b6d84f090eaaa681f1 Author: Olivier Crete <olivier.crete@collabora.com> Date: Mon Jan 23 18:31:54 2017 +0000 audioringbuffer: Also support raw AAC Support raw AAC streams without the ADTS header https://bugzilla.gnome.org/show_bug.cgi?id=777655
(In reply to Vincent Penquerc'h from comment #3) > Created attachment 344062 [details] [review] [review] > raw aac How is that supposed to work? Where would the decoder get the AAC codec_data from?
(In reply to Sebastian Dröge (slomo) from comment #8) > How is that supposed to work? Where would the decoder get the AAC codec_data > from? From GstAudioRingBufferSpec->caps
commit 83e84d5acf4721b29aa498d51862e76d30b4fb34 Author: Tim-Philipp Müller <tim@centricular.com> Date: Mon Jan 23 19:50:09 2017 +0000 audio: add since markers to docs for new enums https://bugzilla.gnome.org/show_bug.cgi?id=777655
Created attachment 344905 [details] [review] audioringbuffer: Prevent overflow of debug names array Add new audio types to the list of strings used for debug so we don't index past the end of that array.
Created attachment 344906 [details] [review] audioringbuffer: Also add FLAC to debug strings. Oops, also add FLAC to the debug strings array.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/332.