After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777655 - audioringbuffer: more encoded formats
audioringbuffer: more encoded formats
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-23 16:34 UTC by Vincent Penquerc'h
Modified: 2018-11-03 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vorbis and flac (2.64 KB, patch)
2017-01-23 16:35 UTC, Vincent Penquerc'h
none Details | Review
wma and alac (2.62 KB, patch)
2017-01-23 16:36 UTC, Vincent Penquerc'h
none Details | Review
raw aac (3.66 KB, patch)
2017-01-23 18:32 UTC, Vincent Penquerc'h
committed Details | Review
audio: add vorbis and FLAC to GstAudioRingBufferFormatType (2.25 KB, patch)
2017-01-23 18:53 UTC, Olivier Crête
none Details | Review
audioringbuffer: add Vorbis to GstAudioRingBufferFormatType (2.25 KB, patch)
2017-01-23 18:55 UTC, Olivier Crête
none Details | Review
audioringbuffer: add wma and alac to encoded audio formats (2.68 KB, patch)
2017-01-23 18:55 UTC, Olivier Crête
none Details | Review
audioringbuffer: Prevent overflow of debug names array (890 bytes, patch)
2017-02-04 03:44 UTC, Jan Schmidt
none Details | Review
audioringbuffer: Also add FLAC to debug strings. (821 bytes, patch)
2017-02-04 03:47 UTC, Jan Schmidt
none Details | Review

Description Vincent Penquerc'h 2017-01-23 16:34:40 UTC
This couple patches add Vorbis, FLAC, ALAC, WMA. The last two are untested, but ought to work given the similarity.
Comment 1 Vincent Penquerc'h 2017-01-23 16:35:54 UTC
Created attachment 344052 [details] [review]
vorbis and flac
Comment 2 Vincent Penquerc'h 2017-01-23 16:36:33 UTC
Created attachment 344053 [details] [review]
wma and alac
Comment 3 Vincent Penquerc'h 2017-01-23 18:32:44 UTC
Created attachment 344062 [details] [review]
raw aac
Comment 4 Olivier Crête 2017-01-23 18:53:52 UTC
Created attachment 344064 [details] [review]
audio: add vorbis and FLAC to GstAudioRingBufferFormatType
Comment 5 Olivier Crête 2017-01-23 18:55:04 UTC
Created attachment 344065 [details] [review]
audioringbuffer: add Vorbis to GstAudioRingBufferFormatType
Comment 6 Olivier Crête 2017-01-23 18:55:27 UTC
Created attachment 344066 [details] [review]
audioringbuffer: add wma and alac to encoded audio formats
Comment 7 Olivier Crête 2017-01-23 18:56:06 UTC
Merge the FLAC and raw AAC support as we've validated them

commit 6134dab3bba13674f82c5befae7e459a67d979ad
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Nov 17 13:04:18 2016 +0000

    audio: add FLAC to GstAudioRingBufferFormatType
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777655

commit c46607095ea5dab7bf42d7b6d84f090eaaa681f1
Author: Olivier Crete <olivier.crete@collabora.com>
Date:   Mon Jan 23 18:31:54 2017 +0000

    audioringbuffer: Also support raw AAC
    
    Support raw AAC streams without the ADTS header
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777655
Comment 8 Sebastian Dröge (slomo) 2017-01-23 19:08:52 UTC
(In reply to Vincent Penquerc'h from comment #3)
> Created attachment 344062 [details] [review] [review]
> raw aac

How is that supposed to work? Where would the decoder get the AAC codec_data from?
Comment 9 Olivier Crête 2017-01-23 19:12:03 UTC
(In reply to Sebastian Dröge (slomo) from comment #8)
> How is that supposed to work? Where would the decoder get the AAC codec_data
> from?

From GstAudioRingBufferSpec->caps
Comment 10 Tim-Philipp Müller 2017-01-23 20:06:54 UTC
commit 83e84d5acf4721b29aa498d51862e76d30b4fb34
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Mon Jan 23 19:50:09 2017 +0000

    audio: add since markers to docs for new enums
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777655
Comment 11 Jan Schmidt 2017-02-04 03:44:29 UTC
Created attachment 344905 [details] [review]
audioringbuffer: Prevent overflow of debug names array

Add new audio types to the list of strings used for debug
so we don't index past the end of that array.
Comment 12 Jan Schmidt 2017-02-04 03:47:09 UTC
Created attachment 344906 [details] [review]
audioringbuffer: Also add FLAC to debug strings.

Oops, also add FLAC to the debug strings array.
Comment 13 GStreamer system administrator 2018-11-03 11:54:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/332.