After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777643 - streamcollection: Supposed to be immutable but nothing enforcing that
streamcollection: Supposed to be immutable but nothing enforcing that
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-23 10:27 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2017-01-23 10:27:34 UTC 
Quoting the docs, "Once posted, a GstStreamCollection is immutable.".

There is nothing enforcing this, and at any time new streams can be added to the collection. The addition of streams is not even thread-safe.


I'd suggest using a GstObject flag, or some new boolean, in the stream collection to mark it is "sealed" (which could be done from application code, but will also be done when the collection is stored in a message). And then make sure that adding new streams fails from that point onwards.

Any opinions on which one is nicer?
Comment 1 Sebastian Dröge (slomo) 2017-02-08 17:58:41 UTC 
Let's go with a sealing function and boolean, it makes it impossible to unseal it again.
Comment 2 GStreamer system administrator 2018-11-03 12:39:00 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/215.