After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777592 - Add minor examples to GDBus and GVariant documentation
Add minor examples to GDBus and GVariant documentation
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-01-21 23:44 UTC by Philip Withnall
Modified: 2017-01-24 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdbus: Add example to docs for g_dbus_method_invocation_return_value() (1.90 KB, patch)
2017-01-21 23:44 UTC, Philip Withnall
committed Details | Review
gvariant: Add example to docs for g_variant_builder_open() (2.36 KB, patch)
2017-01-21 23:44 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2017-01-21 23:44:33 UTC
Patches attached.
Comment 1 Philip Withnall 2017-01-21 23:44:40 UTC
Created attachment 343963 [details] [review]
gdbus: Add example to docs for g_dbus_method_invocation_return_value()

Try to clarify that the variant passed to return_value() must be a
tuple.
Comment 2 Philip Withnall 2017-01-21 23:44:46 UTC
Created attachment 343964 [details] [review]
gvariant: Add example to docs for g_variant_builder_open()

Try to clarify that the type is the type of the container, not of the
items with in it; and give an example of how to use it for nested types.
Comment 3 Matthias Clasen 2017-01-24 08:58:10 UTC
Review of attachment 343963 [details] [review]:

Looks good
Comment 4 Matthias Clasen 2017-01-24 08:59:00 UTC
Review of attachment 343964 [details] [review]:

Sure
Comment 5 Philip Withnall 2017-01-24 09:50:28 UTC
Attachment 343963 [details] pushed as a6e2213 - gdbus: Add example to docs for g_dbus_method_invocation_return_value()
Attachment 343964 [details] pushed as b001f59 - gvariant: Add example to docs for g_variant_builder_open()