GNOME Bugzilla – Bug 777551
Default window size too narrow
Last modified: 2017-03-29 21:50:22 UTC
The default window size of To Do is just a little too small to show three full columns of notes, creating a large awkward blank space where the third column ought to be. It should be a bit wider by default. First impressions!
Created attachment 344427 [details] [review] Change the width of the window to acommodate three lists.
Review of attachment 344427 [details] [review]: ::: src/gtd-window.c @@ +338,3 @@ if (n_elements == 2) gtk_window_set_default_size (GTK_WINDOW (window), + size[0]+32, This is not a good approach. It'd be better if the default size was set in the 'window.ui' file
Created attachment 344430 [details] [review] Change the width of the window to accomodate three lists.
Review of attachment 344430 [details] [review]: Still needs work. Also, the commit message needs to be improved. The GNOME Newcomers guide has a great introduction on what is expected in a commit message, check this out: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines ::: data/ui/window.ui @@ +8,3 @@ <property name="default_height">600</property> + <property name="height_request">600</property> + <property name="width_request">800</property> You should simply change the default_width & default_height properties.
(In reply to Georges Basile Stavracas Neto from comment #4) > Review of attachment 344430 [details] [review] [review]: > > Still needs work. Also, the commit message needs to be improved. The GNOME > Newcomers guide has a great introduction on what is expected in a commit > message, check this out: > https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines > > ::: data/ui/window.ui > @@ +8,3 @@ > <property name="default_height">600</property> > + <property name="height_request">600</property> > + <property name="width_request">800</property> > > You should simply change the default_width & default_height properties. Thank you for the review. But, simply changing default_width & default_height doesn't seem to fix the problem. I keep getting the default_width as 768 instead of 800, when I try to print the width once the application runs. So, I had to include the properties height_request and width_request, which worked fine.
Created attachment 347613 [details] [review] Change default window size to show 3 columns I think the problem was in data/org.gnome.todo.gschema.xml. It seem so be fixed on my machine now.
Review of attachment 347613 [details] [review]: Sweet and short. Looks good!
Thanks for the patch.