After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777551 - Default window size too narrow
Default window size too narrow
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: User Interface
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-21 02:58 UTC by Michael Catanzaro
Modified: 2017-03-29 21:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change the width of the window to acommodate three lists. (851 bytes, patch)
2017-01-27 15:15 UTC, Abishek Kumar
needs-work Details | Review
Change the width of the window to accomodate three lists. (859 bytes, patch)
2017-01-27 16:46 UTC, Abishek Kumar
needs-work Details | Review
Change default window size to show 3 columns (1.19 KB, patch)
2017-03-10 10:54 UTC, Utkarsh Maheshwari
committed Details | Review

Description Michael Catanzaro 2017-01-21 02:58:01 UTC
The default window size of To Do is just a little too small to show three full columns of notes, creating a large awkward blank space where the third column ought to be. It should be a bit wider by default. First impressions!
Comment 1 Abishek Kumar 2017-01-27 15:15:04 UTC
Created attachment 344427 [details] [review]
Change the width of the window to acommodate three lists.
Comment 2 Georges Basile Stavracas Neto 2017-01-27 16:10:04 UTC
Review of attachment 344427 [details] [review]:

::: src/gtd-window.c
@@ +338,3 @@
   if (n_elements == 2)
     gtk_window_set_default_size (GTK_WINDOW (window),
+                                 size[0]+32,

This is not a good approach. It'd be better if the default size was set in the 'window.ui' file
Comment 3 Abishek Kumar 2017-01-27 16:46:52 UTC
Created attachment 344430 [details] [review]
Change the width of the window to accomodate three lists.
Comment 4 Georges Basile Stavracas Neto 2017-01-30 15:48:02 UTC
Review of attachment 344430 [details] [review]:

Still needs work. Also, the commit message needs to be improved. The GNOME Newcomers guide has a great introduction on what is expected in a commit message, check this out: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines

::: data/ui/window.ui
@@ +8,3 @@
     <property name="default_height">600</property>
+    <property name="height_request">600</property>
+    <property name="width_request">800</property>

You should simply change the default_width & default_height properties.
Comment 5 Abishek Kumar 2017-01-30 17:10:07 UTC
(In reply to Georges Basile Stavracas Neto from comment #4)
> Review of attachment 344430 [details] [review] [review]:
> 
> Still needs work. Also, the commit message needs to be improved. The GNOME
> Newcomers guide has a great introduction on what is expected in a commit
> message, check this out:
> https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines
> 
> ::: data/ui/window.ui
> @@ +8,3 @@
>      <property name="default_height">600</property>
> +    <property name="height_request">600</property>
> +    <property name="width_request">800</property>
> 
> You should simply change the default_width & default_height properties.

Thank you for the review. But, simply changing default_width & default_height doesn't seem to fix the problem. I keep getting the default_width as 768 instead of 800, when I try to print the width once the application runs. So, I had to include the properties height_request and width_request, which worked fine.
Comment 6 Utkarsh Maheshwari 2017-03-10 10:54:54 UTC
Created attachment 347613 [details] [review]
Change default window size to show 3 columns

I think the problem was in data/org.gnome.todo.gschema.xml. It seem so be fixed on my machine now.
Comment 7 Georges Basile Stavracas Neto 2017-03-12 17:10:12 UTC
Review of attachment 347613 [details] [review]:

Sweet and short. Looks good!
Comment 8 Georges Basile Stavracas Neto 2017-03-29 21:49:36 UTC
Thanks for the patch.