GNOME Bugzilla – Bug 777531
decodebin3: Update active selection with stream-start
Last modified: 2018-11-03 11:54:01 UTC
When new stream is detected, new stream-collection message should be paired with streams-selected message, in order for application to recognize. However, if active_selection list was not updated with new stream, the streams-selected message never be posted.
Created attachment 343896 [details] [review] decodebin3: Update active selection with stream-start
Created attachment 343897 [details] [review] decodebin3: Make/Post stream-collection by using stream-start Depending on queued buffer size, newly updated stream-collection may be unusable information from application until queued buffers are drained.
Application should use stream-collection for track-change, but multiple streams can exist on a single queue (i.e., multiple stream-start events are there), and mapping future streams with currently available streams is almost impossible from application. Let's assume that queued buffer time in multiqueue is 10 sec. If new stream-collection is posted, the stream-collection message may be unusable information from application until 10 sec amount remaining buffers are drained. Also, although application may want to change track among streams which are not yet drained, newly posted stream-collection message will make application confused. Not only that, application never know exact time that how much time application should wait on for the new streams. (may guess using queued buffer size, but it also cannot guarantee, since there can be multiple streams in a single queue) IMHO, posting a immediately usable stream-collection message from application side seems to make everything simple, not only for application, but decodebin3 also.
Created attachment 343939 [details] [review] decodebin3: Make/Post stream-collection by using stream-start - Change SELECTION_LOCK/UNLOCK position
Created attachment 343945 [details] [review] Add new stream-id to active selection if it is in requested selection
Hello Seungha Yang. I updated to add new stream-id to active selection if it is in requested selection. If not, non-requested stream can be added to active selection. Thanks.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/331.