After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777513 - daemon: Set NoDisplay=true for autostart files
daemon: Set NoDisplay=true for autostart files
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-20 00:41 UTC by Jeremy Bicha
Modified: 2018-01-28 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
daemon: Set NoDisplay=true for autostart files (2.01 KB, patch)
2017-01-20 00:41 UTC, Jeremy Bicha
none Details | Review
daemon: Set NoDisplay=true for autostart files (1.63 KB, patch)
2017-02-08 11:24 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2017-01-20 00:41:48 UTC
This will hide it from the Startup Applications app used in Ubuntu
GNOME no longer ships that app (used to be part of gnome-session) but Ubuntu
patches it back in.

MATE also has a Startup Applications app but it currently ignores the
NoDisplay field:
https://github.com/mate-desktop/mate-session-manager/issues/134

A few years ago, Ubuntu hid all apps from the Startup Applications in the
default install. Several of those patches were submitted upstream but this
is one that wasn't yet.
Comment 1 Jeremy Bicha 2017-01-20 00:41:50 UTC
Created attachment 343848 [details] [review]
daemon: Set NoDisplay=true for autostart files

This hides it from Ubuntu's Startup Applications app
Comment 2 Stef Walter 2017-01-20 10:04:09 UTC
Why not let the user disable autostartup of gnome-keyring?
Comment 3 Jeremy Bicha 2017-02-08 11:24:20 UTC
Created attachment 345186 [details] [review]
daemon: Set NoDisplay=true for autostart files

This hides them from Ubuntu's Startup Applications app

https://bugzilla.gnome.org/show_bug.cgi?id=777513

The SSH service is intentionally shown since there is no other easy
GUI way currently to tell gnome-keyring to let something else handle
ssh-agent.
Comment 4 Jeremy Bicha 2017-02-08 11:27:16 UTC
Stef, after further discussion today, Ubuntu wants to let the SSH Agent service show up in Startup Applications since it's common to have something else handle ssh-agent.

But I don't think we want user to easily disable the other parts of gnome-keyring so I'm attaching the updated patch we are using in Ubuntu.
Comment 5 Jeremy Bicha 2018-01-26 19:24:01 UTC
Stef, the only UI that I am aware of that respects NoDisplay for showing autostart files is Ubuntu's Startup Applications (which was dropped a few years ago from gnome-session upstream). I am unaware of any other distro that ships that.

MATE does have a similar tool but it doesn't respect NoDisplay yet.
https://github.com/mate-desktop/mate-session-manager/issues/134
Comment 6 Stef Walter 2018-01-28 19:01:41 UTC
LGTM. Please merge to master.
Comment 7 Jeremy Bicha 2018-01-28 21:13:00 UTC
Thank you!

Attachment 345186 [details] pushed as 641c87f - daemon: Set NoDisplay=true for autostart files