GNOME Bugzilla – Bug 777484
while building pygobject buildis failing at compiling regress.c
Last modified: 2018-02-08 12:44:43 UTC
When building pygobject it is showing error while compiling /jhbuild/install/share/gobject-introspection-1.0/tests/regress.c due undeclared regress_test_fundamental_hidden_sub_object_get_type(). compiler is showing this as error and build is stopped. This is tested on master right now.
Created attachment 343785 [details] [review] added declaration for regress_test_fundamental_hidden_sub_object_get_type added declaration for regress_test_fundamental_hidden_sub_object_get_type
Review of attachment 343785 [details] [review]: I'm not sure what the point of the test is... ::: tests/scanner/regress.c @@ +3446,3 @@ +_GI_TEST_EXTERN +GType regress_test_fundamental_hidden_sub_object_get_type(void); This is meant to be a hidden type, so it should not be an extern symbol. @@ +3449,3 @@ + +#define _regress_test_fundamental_hidden_sub_object_get_type \ + regress_test_fundamental_hidden_sub_object_get_type You're reversing how this works.
Created attachment 344071 [details] [review] tests: fix compilation with -Werror=missing-prototypes I'm not too familiar with how the scanner works. What we want to avoid is to add Gir data for RegressTestFundamentalHiddenSubObject. So maybe just adding a prototype works?
If the type is public then it's not hidden. :-)
Created attachment 344707 [details] [review] Static declaration added Emmanuele Bassi: Now I added static declaration and didn't reverse macro definition. I think this wont expose "_regress_test_fundamental_hidden_sub_object_get_type" globally.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gobject-introspection/issues/169.