GNOME Bugzilla – Bug 777465
Sound Juicer silently fails to write extracted audio files to a directory which is a symlink
Last modified: 2017-02-13 10:57:59 UTC
Selecting a symlinked directory as the destination for extracted audio files results in Sound Juicer silently ignoring the destination and instead writing to the default output directory. Consistently reproducible using Sound Juicer 3.22.1 on Fedora 25 (package: sound-juicer-3.22.1-1.fc25.x86_64 ). STEPS TO REPRODUCE 1. Execute the following in a suitable directory in a shell: mkdir Test ln -s Test Test2 2. Go to the Sound Juicer UI. Preferences -> Music Folder, select "Test2" as the destination. 3. Rip a CD EXPECTED RESULTS The output files are in the folder Test2 (=Test) ACTUAL RESULTS The output files are in the default output folder ("$HOME/Music" for me) OTHER INFORMATION You can verify with dconf that the configuration option for the destination directory is indeed correctly set.
Thanks for taking the time to report this issue. It looks like sound juicer stopped following symlinks in commit 89f15750 - Use GSettings instead of GConf. I'm not sure why the change was made - I've cc'd Chirstophe to see if he remembers. While there are security issues with following symlinks to temporary files I'm not sure they're that relevant here
I don't really remember, but I don't think this was an intentional change.
Created attachment 344109 [details] [review] Follow symbolic links to when extracting tracks Commit 89f15750 - ‘Use GSettings instead of GConf’ added some checks to make sure the gsettings key for the Music directory referred to a directory. The check does not follow symbolic links which was not the intention so change it to follow them.
Attachment 344109 [details] pushed as a07ff3b - Follow symbolic links to when extracting tracks