After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777417 - week-view: small alignment issue with month and week labels
week-view: small alignment issue with month and week labels
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: Views
unspecified
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-18 02:46 UTC by Mohammed Sadiq
Modified: 2017-01-30 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
month-week label (image) (5.66 KB, image/png)
2017-01-18 02:46 UTC, Mohammed Sadiq 		  Details
Change y-align so that both week and month labels are aligned properly (829 bytes, patch)
2017-01-29 06:31 UTC, Abishek Kumar 		needs-work Details | Review
week-view-header: align month_label,week_label and year_label properly (1.67 KB, patch)
2017-01-30 16:34 UTC, Abishek Kumar 		committed Details | Review

Description Mohammed Sadiq 2017-01-18 02:46:27 UTC 
Created attachment 343689 [details]
month-week label (image)

The month label and week label are not aligned in a line.

Please see the attached screenshot
Comment 1 Abishek Kumar 2017-01-29 06:31:46 UTC 
Created attachment 344471 [details] [review]
Change y-align so that both week and month labels are aligned properly
Comment 2 Georges Basile Stavracas Neto 2017-01-30 15:42:57 UTC 
Review of attachment 344471 [details] [review]:

Almost there! Please, make the other labels (week number and the year) y-aligned to 0 too, so we can protect from any eventual errors.

Also, the commit message needs improvement. The Newcomers guide has a great explanation on how the commit message is expected to be formatted [1].

[1] https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines

Thanks for your patch!
Comment 3 Abishek Kumar 2017-01-30 16:34:23 UTC 
Created attachment 344568 [details] [review]
week-view-header: align month_label,week_label and year_label properly

There was a small alignment issue with week_label, month_label and year_label in week-view.

Change the y-align property of month_label,week_label and year_label in week-header.ui to 0, so that they are aligned properly.
Comment 4 Georges Basile Stavracas Neto 2017-01-30 16:45:48 UTC 
Thanks for the patch. Pushed with an improved commit message.