After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777403 - Calling (file-png-get-defaults) crashes the file-png plug-in
Calling (file-png-get-defaults) crashes the file-png plug-in
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2017-01-17 18:31 UTC by Serge
Modified: 2017-12-29 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GIMP error messages (245.91 KB, image/png)
2017-01-17 18:31 UTC, Serge 		  Details
do not dereference a pointer when it is NULL (1.01 KB, patch)
2017-12-29 06:52 UTC, Massimo 		committed Details | Review

Description Serge 2017-01-17 18:31:27 UTC 
Created attachment 343667 [details]
GIMP error messages

When saving image with the option "Save for Web", crushing plugin "file-png",
GIMP gives the following messages:

-------
Plug-in crashed: "file-png"
(/usr/lib/gimp/2.0/plug-ins/file-png)

Calling error for procedure 'file-png-get-defaults':
Procedure 'file-png-get-defaults' returned no return values
-------

And the file in .png format can not be saved.

However, when I use the menu item "Export as" saving in .png possible.

The "gimp-plugin-registry" was updated from the ppa:otto-kesselgulasch/gimp-edge. This does not give effect.

Screenshot in the attachment.
Comment 1 Michael Schumacher 2017-01-18 08:42:22 UTC 
The best initial step would be to report the issue against the PPA you got GIMP from (I presume it's https://bugs.launchpad.net/~otto-kesselgulasch there) - the maintainers can then examine the issue and forward it upstream if it isn't a build- or platform-specific thing.
Comment 2 Jehan 2017-07-22 21:56:00 UTC 
If not mistaken, "save for web" is not a plugin we ship with GIMP. This is a third party plugin. You should open a bug report to the developers of this plugin.

Though as Schumaml notes, maybe you should open the report to the PPA maintainer since I guess he packaged them together so he may have patched. Also he will know the exact plugin source.

Should we close as NOTGNOME?
Comment 3 Michael Schumacher 2017-07-24 07:56:34 UTC 
Adding the Ubuntu bug tracker URL. 

I think that the maintainer of this PPA is mistaken on the actual reason and uses a "in 2.9, much has changed" catch-all to deal with the issue.
Comment 4 Michael Schumacher 2017-12-29 00:33:47 UTC 
This can be easily provoked by calling (file-png-get-defaults) on the Script-fu console, without involving the save for web plug-in whatsoever.

+ Trace 238304

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
  • #2 g_on_error_stack_trace
  • #3 g_on_error_query
  • #4 gimp_plugin_sigfatal_handler
  • #5 <signal handler called>
  • #6 run
  • #7 gimp_proc_run
  • #8 gimp_loop
  • #9 gimp_main
    at /home/schumaml/devel/source/gimp/libgimp/gimp.c line 618
  • #10 main 






Comment 5


Massimo





          2017-12-29 06:52:46 UTC
        



Created attachment 366069 [details] [review]
do not dereference a pointer when it is NULL

https://git.gnome.org/browse/gimp/commit/plug-ins/common/file-png.c?id=21bed1e2fb438fa5721bddb0573a724ae0024455

moved the lines

+  run_mode = param[0].data.d_int32;
+

without considering the plug-in registers parameterless
procedures






Comment 6


Michael Schumacher





          2017-12-29 11:07:34 UTC
        



Thanks, this fixes the issue.


commit f658ea407153b0676f8e6cbb5010baeab5e93b0d (HEAD -> master)
Author: Massimo Valentini <mvalentini@src.gnome.org>
Date:   Fri Dec 29 07:36:58 2017 +0100

    Bug 777403 - Calling (file-png-get-defaults) crashes the file-png plug-in
    
    commit 21bed1e2fb438fa5721bddb0573a724ae0024455
    
    moved the lines
    
    +  run_mode = param[0].data.d_int32;
    +
    
    without considering the plug-in registers parameterless
    procedures