After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777346 - Feature: Ability to seek track forward/backward using arrow keys.
Feature: Ability to seek track forward/backward using arrow keys.
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 776668
Blocks:
 
 
Reported: 2017-01-16 16:59 UTC by Abhinav Singh
Modified: 2017-04-25 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Feature - forward/backward seek track using arrow (2.24 KB, patch)
2017-01-16 17:20 UTC, Abhinav Singh
none Details | Review
player.py: seek songs using arrow keys (1.61 KB, patch)
2017-03-04 15:56 UTC, Abhinav Singh
committed Details | Review

Description Abhinav Singh 2017-01-16 16:59:38 UTC
It is an essential feature that user has the ability to seek forward, backward using arrow keys. Most music players provide this and it has become a habit for us.

I suggest the following shortcuts:

If progress bar is focused:
-left/right seeks the track by -/+ 5 seconds.

If progress bar is not focused:
-shift + left/right seeks the track by -/+ 5 seconds.

We do not need variations like ctrl + left/right for -/+ 10 seconds, IMO.

Note:
-while holding the key, the track should be paused.
Comment 1 Abhinav Singh 2017-01-16 17:20:48 UTC
Created attachment 343577 [details] [review]
Feature - forward/backward seek track using arrow

This patch reuses the code that enabled the user to seek the track using mouse.
key-press-event and key-released-event are used just like the button-events were connected to and used.

--------------
double clicking on the seek/progress bar pauses the playing song.

https://bugzilla.gnome.org/show_bug.cgi?id=776668#c1

Progress scale's button press event was getting called multiple times before a single button release event was called. This messed up the last state of the player, and caused it to pause. This might be a bug with how gtk/gdk handles events.
---------------

It had come to my notice that I could not *reuse* mouse seek track's functionality for arrow seek track unless that bug is fixed.

Hence this patch is stacked over that patch.
Comment 2 Marinus Schraal 2017-02-13 21:23:41 UTC
Looks like a nice addition, however there are some issues with the patch this is depending on still.
Comment 3 Abhinav Singh 2017-03-04 15:56:09 UTC
Created attachment 347215 [details] [review]
player.py: seek songs using arrow keys
Comment 4 Marinus Schraal 2017-04-25 09:51:15 UTC
Thanks for the patch.