After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777331 - qtmux: Don't write Sync Sample Atom for ProRes
qtmux: Don't write Sync Sample Atom for ProRes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-16 14:49 UTC by Georg Lippitsch
Modified: 2017-01-16 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtmux: Don't write Sync Sample Atom for ProRes (769 bytes, patch)
2017-01-16 14:49 UTC, Georg Lippitsch 		committed Details | Review

Description Georg Lippitsch 2017-01-16 14:49:35 UTC 
Created attachment 343559 [details] [review]
qtmux: Don't write Sync Sample Atom for ProRes

'sync' should only be true for I-frame codecs, so set it to false when muxing ProRes.
Comment 1 Sebastian Dröge (slomo) 2017-01-16 14:54:04 UTC 
But ProRes is I-frame-only, so every buffer would be sync=true? Or am I missing something here?

You could omit the flag completely from the sample in theory, by storing that information in the default sample flags in one of the other boxes.
Comment 2 Georg Lippitsch 2017-01-16 15:04:49 UTC 
Ups, comment was wrong. Other way round: sync should be false for I-frame codecs and true for Long-GOP.
Same is done for other codecs, like jpeg or dv.
Comment 3 Sebastian Dröge (slomo) 2017-01-16 17:29:33 UTC 
Attachment 343559 [details] pushed as d71c06c - qtmux: Don't write Sync Sample Atom for ProRes