After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777246 - Overview totally broken due to new local file restrictions
Overview totally broken due to new local file restrictions
Status: RESOLVED NOTGNOME
Product: epiphany
Classification: Core
Component: Overview
3.23.x
Other Linux
: Normal blocker
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-14 03:28 UTC by Michael Catanzaro
Modified: 2017-01-14 23:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Catanzaro 2017-01-14 03:28:59 UTC 
Overview is totally broken with WebKit trunk due to new local file restrictions. Seems to be impossible to load file:/// URLs from ephy-about:// pages. A quick check of our API doesn't show any way to fix it; nothing in WebKitSecurityManager seems relevant.
Comment 1 Michael Catanzaro 2017-01-14 03:29:19 UTC 
(Note: also affects our empty state)
Comment 2 Michael Catanzaro 2017-01-14 22:08:14 UTC 
I added a WTFLogAlways in WebCore::CachedResourceLoader::canRequest. It prints e.g.:

canRequest: security origin ephy-about:// cannot display file:///home/mcatanzaro/.cache/thumbnails/large/80bbf48dad9161583129da74239ab0bc.png

So what we need is some way to tell WebKit that ephy-about:// is trusted and allowed to load local files, without allowing other URI schemes to do so.
Comment 3 Michael Catanzaro 2017-01-14 22:09:52 UTC 
Turns out we already have code to solve this in ephy_embed_shell_startup:

  /* Register about scheme as local so that it can contain file resources */
  webkit_security_manager_register_uri_scheme_as_local (webkit_web_context_get_security_manager (priv->web_context),
                                                        EPHY_ABOUT_SCHEME);

It works with 2.14.2, but is broken with WebKit trunk.
Comment 4 Michael Catanzaro 2017-01-14 23:03:53 UTC 
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=167058