After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777212 - urisourcebin: Fix crash during EOS handling
urisourcebin: Fix crash during EOS handling
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-13 10:45 UTC by Seungha Yang
Modified: 2018-11-03 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
urisourcebin: Fix crash during EOS handling (1.91 KB, patch)
2017-01-13 10:46 UTC, Seungha Yang 		none Details | Review
reproduced log (1.91 KB, text/plain)
2017-07-02 11:04 UTC, Seungha Yang 		  Details
urisourcebin: Fix crash during EOS handling (1.90 KB, patch)
2017-07-02 11:09 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2017-01-13 10:45:25 UTC 
Slot has two cases to receive fake EOS.
  a) actual EOS from demuxer's pad
  b) demuxer's pad-removed.
When a) happened, slot is still marked as linked.
And when b) happend, slot will be marked as unlinked.

Sometimes, following sequence is possible, and it causes crash
* demuxer pushed EOS (fake-eos-A)
* Then, the demuxer's pad was removed (fake-eos-A)
* slot's srcpad got "fake-eos-A" but it was already marked as unlinked by
  pad-removed. So, urisourcebin will throw the slot to threadpool to remove it.
* "fake-eos-B" reached to slot's src pad and trying to free the slot again.
Comment 1 Seungha Yang 2017-01-13 10:46:18 UTC 
Created attachment 343423 [details] [review]
urisourcebin: Fix crash during EOS handling
Comment 2 Seungha Yang 2017-07-02 11:04:20 UTC 
Created attachment 354793 [details]
reproduced log
Comment 3 Seungha Yang 2017-07-02 11:09:36 UTC 
Created attachment 354794 [details] [review]
urisourcebin: Fix crash during EOS handling

Fix typo in commit message.

Crash can be easily produced when TRICKMODE_NO_AUDIO is being enabled on dashdemux use case
Comment 4 GStreamer system administrator 2018-11-03 11:53:41 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/327.