After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777192 - Use gtk_popover.popup()/popdown()
Use gtk_popover.popup()/popdown()
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-12 20:47 UTC by Marcus Lundblad
Modified: 2017-06-11 20:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
osmEditDialog: Use gtk_popover_popup/popdown() for hints (999 bytes, patch)
2017-06-11 20:46 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-01-12 20:47:53 UTC
In the OpenStreetMap editing dialog there is a popover that is used for
the hint "bubble" shown when clicking the lightbulb hint button in text fields
and spinner widgets.
Currently the popover is shown/hidden by setting the "visible" property.
A better alternative (available since GTK+ 3.22) is to use
gkt_popover_popup()/gtk_popover_popdown() to show/hide the popover.
The benefit is that we will then get a subte fade-in/out animation instead of
just abruptly showing/hiding (this is also how it's done internally in
GtkMenuButton when it's using a popover, such as the "Add field" button in the
same dialog).
Comment 1 Marcus Lundblad 2017-06-11 20:46:58 UTC
Created attachment 353582 [details] [review]
osmEditDialog: Use gtk_popover_popup/popdown() for hints
Comment 2 Marcus Lundblad 2017-06-11 20:47:39 UTC
Attachment 353582 [details] pushed as 69e93e1 - osmEditDialog: Use gtk_popover_popup/popdown() for hints