GNOME Bugzilla – Bug 777179
[PATCH] network: switch from libnm-glib to libnm
Last modified: 2017-02-23 12:35:43 UTC
Created attachment 343381 [details] [review] [PATCH] network: switch from libnm-glib to libnm Initial setup is one of the few components that keep NetworkManager-glib in distribution. Let's fix that.
Ping?
Review of attachment 343381 [details] [review]: thanks for the patch! ::: gnome-initial-setup/pages/network/gis-network-page.c @@ +91,3 @@ /* is this the same type and data? */ + if (nm_utils_same_ssid (g_bytes_get_data (ssid, NULL), g_bytes_get_size (ssid), + g_bytes_get_data (ssid, NULL), g_bytes_get_size (ssid_tmp), TRUE)) { ssid_tmp on the second line's first argument? @@ +411,1 @@ + connection = nm_client_activate_connection_finish (client, result, &error); isn't this leaked? @@ +428,3 @@ + GError *error = NULL; + + connection = nm_client_add_and_activate_connection_finish (client, result, &error); leaked? ::: gnome-initial-setup/pages/network/network-dialogs.c @@ +80,3 @@ + GError *error = NULL; + + connection = nm_client_activate_connection_finish (client, result, &error); this is leaked, no? @@ +96,3 @@ + GError *error = NULL; + + connection = nm_client_add_and_activate_connection_finish (client, result, &error); leaked?
Created attachment 346429 [details] [review] [PATCH v2] network: switch from libnm-glib to libnm Thanks for the review. Updated version of the patch, fixes all of the above.
Review of attachment 346429 [details] [review]: Please add this bug's URL to the commit message. Otherwise looks good, thanks
IIRC you don't have gnome git access so I'll push it. You should ask for that git account :-)