GNOME Bugzilla – Bug 777178
[PATCH] libtracker-miner: port to libnm
Last modified: 2017-07-24 13:52:23 UTC
Created attachment 343376 [details] [review] [PATCH] libtracker-miner: port to libnm It's the perferred NetworkManager's library for a couple of years now already. Keep compatibility with the older one, since it's reasonably similar. --- Just compile-tested this with libnm. May need some more love.
Ping?
Hello?
Comment on attachment 343376 [details] [review] [PATCH] libtracker-miner: port to libnm Sorry the pings fell off the radar... The patch looks good for the master branch. How long do you think makes sense to preserve the libnm-glib paths?
(In reply to Carlos Garnacho from comment #3) > Comment on attachment 343376 [details] [review] [review] > [PATCH] libtracker-miner: port to libnm > > Sorry the pings fell off the radar... The patch looks good for the master > branch. How long do you think makes sense to preserve the libnm-glib paths? I wouldn't miss it and given it's an optional feature and I think it would make sense to remove it now. But that mainly depends on which platforms do you care about supporting. libnm exists since December 2014, RHEL 7 has it; the current Debian stable doesn't have it; the most recent Ubuntu LTS has it (sorry I don't know the version numbers).
Thanks, that's all I wanted to know :). I think it's indeed a good time to just drop the older support. If it's just debian stable which is missing it, people will have to put up with the extra dep, or not compiling the optional feature if they want to try the latest and greatest Tracker (tracker-miner-rss is the only affected daemon in practice, which is scarcely used) But I doubt Tracker 1.12 will end up in stable through Debian channels, at least without a matching NM, nor in quite a while :). I can change the patch during the weekend and push to master, if you don't/can't get to it.
Pulled the patch to master now; dropping the libnm-glib compat code and a minor adjustment for the meson-based build.
Excellent, thanks :)