After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777174 - qtmux resets request pad counters on PAUSED->READY
qtmux resets request pad counters on PAUSED->READY
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-12 13:43 UTC by Jan Schmidt
Modified: 2017-01-16 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtmux: Don't reset request pad numbering across uses (1.27 KB, patch)
2017-01-12 13:44 UTC, Jan Schmidt
committed Details | Review

Description Jan Schmidt 2017-01-12 13:43:37 UTC
qtmux resets some internal counters when dropping back to READY that mean subsequent audio_%d and video_%d request pads start from 0 again. That's wrong, because request pads have a lifetime across reuses of the element.
Comment 1 Jan Schmidt 2017-01-12 13:44:05 UTC
Created attachment 343360 [details] [review]
qtmux: Don't reset request pad numbering across uses

When reset, don't restart request pad numberings, as
request pads can survive across state changes. Only
restart at 0 if all request pads are handed back first.
Comment 2 Jan Schmidt 2017-01-12 23:44:47 UTC
Pushed:

commit b0e38ed374c369947fca4363faa8f773b572e638
Author: Jan Schmidt <jan@centricular.com>
Date:   Fri Jan 13 00:01:06 2017 +1100

    qtmux: Don't reset request pad numbering across uses
    
    When reset, don't restart request pad numberings, as
    request pads can survive across state changes. Only
    restart at 0 if all request pads are handed back first.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777174