GNOME Bugzilla – Bug 777127
pressing back after no search results from single album view leads to force close
Last modified: 2017-01-16 09:33:58 UTC
Pressing back button (in the toolbar) after getting no search results from single-albumview (Albumwidget.ui) leads to force close of the application. Reproduce: click on an album from album view click search, and type something such that no results are found press back button Observations: the force close only happens if the search results are zero Expected : should go back from single-album to albums view
Created attachment 343294 [details] [review] fixes the force close The file was missing a dependency.
Nice catch. Coming at it from a different angle, should there be a backbutton when we search? It's really a different mode, maybe make the backbutton not usable? While testing this I find the following bug: * in albums view->select an album * while there, search for another existing album->select it * press the back button and you get back to the search view (alright) * dismiss the search view and you are left with the first selected album, but no back button I think the whole interaction model for subviews + search is a bit weird. If you search and you change a view, the search is gone. If you search in a subview (like a specific album view) you can actually sometimes go back and sort of switch views. This is unwanted behaviour imo, it should cancel the search or not be allowed.
I understand that there can be two options : 1> Disable back button when search is there. 2> Cancel search when back is pressed. I feel like the 2nd one is better, because many times the users will use the back button to exit search. It is not very intuitive to disable search only with search button. I shall make a patch for 2nd option, if you agree.
I agree that option 2 is probably the most logical and in line what the views do. So if you can provide a patch for that, that would be great.
Review of attachment 343294 [details] [review]: lgtm
Thanks for the fix. Rewrote the commit msg somewhat.