After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777101 - rtspsrc: tcp interleaved data dropped if first sub-streams are skipped during SETUP
rtspsrc: tcp interleaved data dropped if first sub-streams are skipped during...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 777224 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-01-10 16:24 UTC by Matt Staples
Modified: 2017-01-27 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
only match configured streams in find_stream_by_channel (1013 bytes, patch)
2017-01-10 16:46 UTC, Matt Staples 		none Details | Review
only match configured streams in find_stream_by_channel (1013 bytes, patch)
2017-01-25 14:26 UTC, Matt Staples 		committed Details | Review

Description Matt Staples 2017-01-10 16:24:42 UTC 
If the first stream(s) are explicitly skipped during SETUP (e.g., if it's disabled via SIGNAL_SELECT_STREAM), and tcp-interleaved is used, then you can have a state where streams[0] is unconfigured, and streams[1] is configured with channel number 0.
Subsequent calls to find_stream_by_channel then return the unconfigured stream[0], since it happens to be the first match against channel number 0.  That results in all incoming data for stream 0 getting dropped (with a warning).
Comment 1 Matt Staples 2017-01-10 16:46:13 UTC 
Created attachment 343258 [details] [review]
only match configured streams in find_stream_by_channel
Comment 2 Matt Staples 2017-01-25 14:26:10 UTC 
Created attachment 344222 [details] [review]
only match configured streams in find_stream_by_channel

I don't think my previous patch was uploaded correctly - re-uploaded as plain text.
Comment 3 Sebastian Dröge (slomo) 2017-01-26 13:32:10 UTC 
commit a8eb0515f1e3b096f978189cfd3cd01d576f390f
Author: Matt Staples <staples255@gmail.com>
Date:   Tue Jan 10 09:40:56 2017 -0700

    rtspsrc: find_stream_by_channel should ignore unconfigured streams
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777101
Comment 4 Sebastian Dröge (slomo) 2017-01-26 13:59:10 UTC 
*** Bug 777224 has been marked as a duplicate of this bug. ***