After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777088 - tsdemux: Expose new pads if got new stream-start
tsdemux: Expose new pads if got new stream-start
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-10 13:47 UTC by Seungha Yang
Modified: 2018-11-03 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tsdemux: Expose new pads if got new stream-start (8.17 KB, patch)
2017-01-10 13:48 UTC, Seungha Yang 		none Details | Review
tsdemux: Change srcpad naming to indicate created sequence (3.16 KB, patch)
2017-01-10 13:48 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2017-01-10 13:47:04 UTC 
If upstream pushes new stream-start event with updated stream-id,
nobody can guarantee that newly incoming stream is identical to the previous one.
So, demux should expose new pads whatever previously demux has.
This is to fix the case that codec/stream configuration change
with hls bitrate switching.
Comment 1 Seungha Yang 2017-01-10 13:48:03 UTC 
Created attachment 343243 [details] [review]
tsdemux: Expose new pads if got new stream-start
Comment 2 Seungha Yang 2017-01-10 13:48:32 UTC 
Created attachment 343244 [details] [review]
tsdemux: Change srcpad naming to indicate created sequence

Since newly exposed pad might have same program number and PID,
includes creation sequence number to differentiate them.
Comment 3 Seungha Yang 2017-01-10 13:51:25 UTC 
With playbin3, it makes me hard that existing demux elements are re-used.
So, such period change or bitrate switch driven new stream-start event must be correctly handled by demux, since the new stream-id in stream-start is the only clue.
Comment 4 GStreamer system administrator 2018-11-03 14:03:08 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/506.