After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777064 - Fix grammatically incorrect "Try another search criteria", etc.
Fix grammatically incorrect "Try another search criteria", etc.
Status: RESOLVED FIXED
Product: gnome-characters
Classification: Other
Component: general
3.22.x
Other All
: Normal minor
: ---
Assigned To: GNOME Characters maintainer(s)
GNOME Characters maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-09 22:52 UTC by Daniel Boles
Modified: 2017-01-10 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
characterlist.ui: Improve the 'no result' strings (1.27 KB, patch)
2017-01-09 22:56 UTC, Daniel Boles 		committed Details | Review

Description Daniel Boles 2017-01-09 22:52:50 UTC 
"Criteria" is the plural, for the singular "criterion", so I guess this should be changed to one of the following:

 * "Try other search criteria" ...but this implies there is more than one criterion ;-) whereas we only have a search string, nothing else, so just one.
 * "Try another search" - and here, the "criterion" doesn't seem useful to keep.

I vote for the second, but it's up to you!

While here, I'd also suggest changing "Search produced empty result" to "Search found no results", but that's just personal preference really! :-)

I'm happy to submit or simply commit a patch for whatever, if anything, you decide.

Thanks for the really handy program!
Comment 1 Daniel Boles 2017-01-09 22:56:44 UTC 
Created attachment 343202 [details] [review]
characterlist.ui: Improve the 'no result' strings

I settled for "Try a different search", since I felt "Try another search" sounded a little too much like 'Do another search for the same thing, and eventually it might work!' ;-)
Comment 2 Daiki Ueno 2017-01-10 08:32:42 UTC 
Review of attachment 343202 [details] [review]:

Thanks, looks good to me.
Comment 3 Daniel Boles 2017-01-10 11:42:10 UTC 
Thanks!