GNOME Bugzilla – Bug 777011
general: use own icon instead of system-file-manager
Last modified: 2017-01-09 18:33:06 UTC
Since adwaita-icon-theme no longer the system-file-manager icon, we must our own.
Created attachment 343123 [details] [review] general: use own icon instead of system-file-manager
Review of attachment 343123 [details] [review]: This is missing from https://git.gnome.org/browse/nautilus/commit/?id=7a9eacc0afa53520eef12542c4d330bf66142200 right? If that's the case, that was quite a bad job from my part... :/ If that's the case, can you mention it in the commit message? Otherwise looks good and feel free to commit, thanks Ernestas!
(In reply to Carlos Soriano from comment #2) > Review of attachment 343123 [details] [review] [review]: > > This is missing from > https://git.gnome.org/browse/nautilus/commit/ > ?id=7a9eacc0afa53520eef12542c4d330bf66142200 right? If that's the case, that > was quite a bad job from my part... :/ > If that's the case, can you mention it in the commit message? > Otherwise looks good and feel free to commit, thanks Ernestas! No, we’ve got a brand new icon now: https://git.gnome.org/browse/nautilus/commit/?id=8b7dbcdda887177bc17bb5a49c14c059f4a19d3f The commit that caused the issue: https://git.gnome.org/browse/adwaita-icon-theme/commit/?id=9245e5a3651ec97b4b2dfbf104ba2c16bdc82509
It’s also thanks to Hussam that I uncovered this. It’s not really straightforward how you notice that the icon is missing.
Well the pourpose of https://git.gnome.org/browse/nautilus/commit/?id=7a9eacc0afa53520eef12542c4d330bf66142200 is to use that everywhere in nautilus instead of system-file-manager, not sure how I overlooked those you fixed now :/ So yeah point to that commit in the mesaage and push :)
(In reply to Carlos Soriano from comment #5) > Well the pourpose of > https://git.gnome.org/browse/nautilus/commit/ > ?id=7a9eacc0afa53520eef12542c4d330bf66142200 is to use that everywhere in > nautilus instead of system-file-manager, not sure how I overlooked those you > fixed now :/ > > So yeah point to that commit in the mesaage and push :) Oh, sure. I didn’t realize that.
Created attachment 343178 [details] [review] general: use own icon instead of system-file-manager Since adwaita-icon-theme no longer ships the system-file-manager icon, we must our own. 7a9eacc0afa53520eef12542c4d330bf66142200 was to include this change, as part of Flatpak integration.
Attachment 343178 [details] pushed as 028a0e9 - general: use own icon instead of system-file-manager