GNOME Bugzilla – Bug 776940
Log message if extension could not be installed
Last modified: 2017-11-21 18:17:01 UTC
Created attachment 343013 [details] [review] patch proposal v1 Currently if one tries to install an extension and it fails, the last logs he will find are unzip ones, eg: > janv. 06 13:11:11 host org.gnome.Shell.desktop[1039]: inflating: /home/gautier/.local/share/gnome-shell/extensions/apps-menu@gnome-shell-extensions.gcampax.github.com/locale/km/LC_MESSAGES/gnome-shell-extensions.mo > janv. 06 13:11:11 host org.gnome.Shell.desktop[1039]: extracting: /home/gautier/.local/share/gnome-shell/extensions/apps-menu@gnome-shell-extensions.gcampax.github.com/metadata.json This is very confusing, because since the extension failed to be installed, /home/gautier/.local/share/gnome-shell/extensions/apps-menu@gnome-shell-extensions.gcampax.github.com/ folder will actually be deleted! The attached patch simply log any error so that user now that the application has not been installed: > GNOME Shell-Message: Error while installing apps-menu@gnome-shell-extensions.gcampax.github.com: LoadExtensionError (Error: Requiring GMenu, version none: Typelib file for namespace 'GMenu' (any version) not found) Obviously one can see using dbus-monitor the given error, but I think it is worth logging it to "standard" logs as well. The next big improvement would be to actually handle the error on extensions.gnome.org website, because currently the switch just switch to "OFF" and nothing more happen. It would be great to display the "ERROR" button, but I don't know it is feasible?
> It would be great to display the "ERROR" button, but I don't know > it is feasible? If GNOME Shell will send proper DBus responce, then yes, it's feasible. GNOME Shell already returns errors for many handled cases, but e.g.o. currently do not handle them at all. I will fix this at near future.
Thanks Yuri for the comment. While handling the issue properly would be great, could you still apply the submitted patch so that one can see errors in system logs? Thanks!
> could you still apply the submitted patch I'm not GNOME Shell developer so you should wait until someone else will review it.
Review of attachment 343013 [details] [review]: Sure.
Pushed as commit 35a9c3e