After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776915 - Piwigo sharing doesn't POST image
Piwigo sharing doesn't POST image
Status: RESOLVED INVALID
Product: shotwell
Classification: Other
Component: web-sharing
0.25.x
Other Linux
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-05 20:24 UTC by bugs
Modified: 2017-03-10 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
capture of 0.25.1 POST (2.38 KB, text/plain)
2017-01-05 20:24 UTC, bugs
Details
capture of 0.24.0 POST (3.31 KB, text/plain)
2017-01-05 20:25 UTC, bugs
Details

Description bugs 2017-01-05 20:24:11 UTC
Created attachment 342981 [details]
capture of 0.25.1 POST

With 0.25.1 publishing images to Piwigo does not work. New category is created in Piwigo as requested but images do not appear. No error is shown in GUI or emitted on CLI.
Packet capture with Wireshark shows that Piwigo returns "forbidden file type" in response [note that's it - no XML or anything, just those three words]. 
Test image is a 17kB JPEG.
I installed 0.24.0 and it works as expected.
I did a packet capture of the transaction with each version and I observed that the POST from 0.25.1 is much smaller than 0.24 and doesn't actually seem to include the image.
Comment 1 bugs 2017-01-05 20:25:28 UTC
Created attachment 342982 [details]
capture of 0.24.0 POST
Comment 2 Jens Georg 2017-01-05 21:33:54 UTC
Can you try with master? I think this is the same issue as upload with flickr failing.
Comment 3 bugs 2017-01-05 22:06:49 UTC
I have built as per https://wiki.gnome.org/Apps/Shotwell/BuildingAndInstalling and that gave me 0.25.2 but it behaves just the same as 0.25.1.
Comment 4 Jens Georg 2017-01-06 11:46:25 UTC
Odd. Works here. What kind of image are you trying to upload?

Would you be comfortable with git bisect?
Comment 5 bugs 2017-01-06 11:59:37 UTC
If you can point me at the URLs to git clone from then yeah, I'll give 
it a go.

I have tested with everything from ~30kB - 10MB JPEGs. I'll have a go 
with a PNG just to be sure.

It occurs to me that 0.25.2 may not be trunk? I just did a git clone of 
the base URL, should I have cloned this instead?: 
https://git.gnome.org/browse/shotwell/log/
Comment 6 Jens Georg 2017-01-06 17:59:56 UTC
Cloning the base url should give you master.

0.25.2 is fine, it has the version of the last release that was done, it should also show you a git hash on command line when it starts.

What's the output of git describe HEAD?


basically, you do change to the top level of the repository

git checkout shotwell-0.25.1
git bisect start
git bisect bad
git checkout shotwell-0.24.0
git bisect good

then build, test and repeat good/bad depending whether the upload succeeds or not
Comment 7 bugs 2017-01-07 12:19:49 UTC
The final result I get after multiple bisections is:

$ git bisect bad
b6d70e14df54f4cf39f050682271f5cdd7b52aa8 is the first bad commit
commit b6d70e14df54f4cf39f050682271f5cdd7b52aa8
Author: Anders Jonsson <anders.jonsson@norsjovallen.se>
Date:   Wed Sep 21 11:26:55 2016 +0000

    Updated Swedish translation

:040000 040000 a0a2355ce1117c9b07d222187bff08503cc46ab3 9cdaca1540bda6f692316ba28200383363f00a9b M      help

I have had a look through https://git.gnome.org/browse/shotwell/commit/?id=b6d70e14df54f4cf39f050682271f5cdd7b52aa8 and it's not 100% clear to me that anything in there would cause this but a) I'd never heard of Vala until I started digging into this bug and b) this is the first time I've ever done a git bisect.

To be clear, this is what I did, from the directory that shotwell was git clone'd into:

  675  ./autogen.sh && make && make install
  676  git bisect bad
  677  ./autogen.sh && make && make install
  678  git bisect bad
  679  ./autogen.sh && make && make install
  680  git bisect bad
  681  ./autogen.sh && make && make install
  682  git bisect bad
Comment 8 Jens Georg 2017-01-07 13:18:22 UTC
did you check whether the upload really doesn't work? Ending up in a translation usually is a sign from accidentally doing a wrong bad or good.
Comment 9 bugs 2017-01-07 15:49:39 UTC
Yes, I have to check through a browser every time because there's never any indication in Shotwell that it didn't work. I will wipe and start again.

Also, where are the Piwigo account settings kept? I blew away everything I could find under ~/ with the word 'shotwell' in but it seems to remember the Piwigo settings somehow.
Comment 10 bugs 2017-01-07 17:24:17 UTC
So I blew away the shotwell/ directory I had cloned, cloned it again, built, tested, and guess what - it's working fine with 0.25.2. Hmm. Reinstalled 0.25.1 package, tested, working fine. 0.24.0 still works too.
I am baffled by all of this and feel like I've wasted quite a bit of time, but hey, it's working...