After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776899 - v4l2: Remove usage and definition of LOG_CAPS macro
v4l2: Remove usage and definition of LOG_CAPS macro
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-05 13:54 UTC by Michael Tretter
Modified: 2017-01-16 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
v4l2: Remove usage and definition of LOG_CAPS macro (3.82 KB, patch)
2017-01-05 13:56 UTC, Michael Tretter
none Details | Review
v4l2: Remove usage and definition of LOG_CAPS macro (3.82 KB, patch)
2017-01-05 14:01 UTC, Michael Tretter
committed Details | Review

Description Michael Tretter 2017-01-05 13:54:40 UTC
Unlike former definitions of LOG_CAPS, the current implementation simply expands to GST_DEBUG_OBJECT. The LOG_CAPS macro is rarely used and most uses duplicate already existing GST_DEBUG_OBJECT lines. Therefore, the caps are often printed twice which unnecessarily clutters the debug log.
                                                                        
Replace LOG_CAPS calls with GST_DEBUG_OBJECT, remove LOG_CAPS calls, and delete the definition of LOG_CAPS.
Comment 1 Michael Tretter 2017-01-05 13:56:06 UTC
Created attachment 342953 [details] [review]
v4l2: Remove usage and definition of LOG_CAPS macro
Comment 2 Michael Tretter 2017-01-05 14:01:26 UTC
Created attachment 342956 [details] [review]
v4l2: Remove usage and definition of LOG_CAPS macro

I messed up the bugzilla link in the commit message and had to fix the link.
Comment 3 Nicolas Dufresne (ndufresne) 2017-01-16 15:29:30 UTC
Review of attachment 342956 [details] [review]:

I agree.
Comment 4 Nicolas Dufresne (ndufresne) 2017-01-16 15:30:50 UTC
Attachment 342956 [details] pushed as eb25b05 - v4l2: Remove usage and definition of LOG_CAPS macro