After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776868 - Improve the documentation of GtkEntry:attributes
Improve the documentation of GtkEntry:attributes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
3.89.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-01-04 15:22 UTC by Sébastien Wilmet
Modified: 2017-01-04 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
docs: improve the documentation of GtkEntry:attributes (1.02 KB, patch)
2017-01-04 15:23 UTC, Sébastien Wilmet 		committed Details | Review

Description Sébastien Wilmet 2017-01-04 15:22:33 UTC 
I'll attach a patch. gspell relies on this.
Comment 1 Sébastien Wilmet 2017-01-04 15:23:35 UTC 
Created attachment 342852 [details] [review]
docs: improve the documentation of GtkEntry:attributes

See the implementation of gtk_entry_create_layout():
pango_attr_list_splice() is used to add the PangoAttrList of the preedit
string. And that is done *after* applying the PangoAttrList of the
"attributes" property.
Comment 2 Matthias Clasen 2017-01-04 18:27:28 UTC 
Review of attachment 342852 [details] [review]:

sure, ok
Comment 3 Sébastien Wilmet 2017-01-04 18:58:01 UTC 
Thanks for the quick review.

Attachment 342852 [details] pushed as 88699f5 - docs: improve the documentation of GtkEntry:attributes