After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776865 - About dialog window is not modal
About dialog window is not modal
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-04 14:38 UTC by Dimitrios Christidis
Modified: 2017-01-05 02:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.62 KB, patch)
2017-01-04 14:39 UTC, Dimitrios Christidis 		committed Details | Review

Description Dimitrios Christidis 2017-01-04 14:38:43 UTC 
Making the About dialog window modal will improve consistency with other GNOME applications. Additionally, centred window placement does not work on Wayland (see bug #761336). Making it modal can act as a workaround.
Comment 1 Dimitrios Christidis 2017-01-04 14:39:22 UTC 
Created attachment 342845 [details] [review]
Proposed fix
Comment 2 Christian Hergert 2017-01-05 02:41:09 UTC 
This would block all input to other windows while the dialog is displayed. This is not what we want, which does differ from many other GNOME applications. Sort of goes with the territory of being a content creation app vs a consumption app.

It would be nice to fix any issues with Wayland, so we can leave this bug open for that, but I don't want to make the dialog modal. Perhaps we can use GTK_WIN_POS_CENTER_ON_PARENT.
Comment 3 Christian Hergert 2017-01-05 02:46:51 UTC 
Ah okay, I see now, as long as we fix bug 776864 this should be okay.
Comment 4 Christian Hergert 2017-01-05 02:51:13 UTC 
Thanks!