GNOME Bugzilla – Bug 776801
uninstalled target broken
Last modified: 2017-01-03 17:47:05 UTC
https://cgit.freedesktop.org/gstreamer/gst-build/commit/?id=9a64b727bf6ad42d66f1e5f0404baca46f57167c broke the "uninstalled" target: $ ninja-build -C build/ uninstalled ninja: Entering directory `build/' [0/1] 'Running external command uninstalled.' /usr/bin/python3: can't open file 'mesonintrospect': [Errno 2] No such file or directory FAILED: uninstalled '/usr/bin/python3' '/usr/bin/meson' '--internal' 'commandrunner' '/home/cassidy/dev/gst/master/gst-build' '/home/cassidy/dev/gst/master/gst-build/build' '' '/home/cassidy/dev/gst/master/gst-build/gst-uninstalled.py' '--builddir=/home/cassidy/dev/gst/master/gst-build/build' '--gst-version=master' ninja: build stopped: subcommand failed.
Created attachment 342754 [details] [review] gst-uninstalled: fix mesonintrospect invocation The mesonintrospect variable now contains the name of the executable installed on the system and no longer its full path. (9a64b727bf6ad42d66f1e5f0404baca46f57167c) So passing it as argument to the python interpreter is no longer working as it won't find the file. Fix this by calling the executable directly which is fine as it was returned by shutil.which(). It's also cleaner as there is no reason to assume that mesonintrospect is a python file.
Review of attachment 342754 [details] [review]: This is not going to work on windows in the case we use a local checkout of meson (which is the default in a msys2 environment), I think we should revert the part from 9a64b727bf6ad42d66f1e5f0404baca46f57167c where we stop returning full path as we do not know anymore if we will get a full path or not out of get_meson().